Skip to content

Commit

Permalink
CustomSelectControlV2: do not flip popover if legacy adapter (WordPre…
Browse files Browse the repository at this point in the history
…ss#63357)

* CustomSelectContorlV2: do not flip if legacy adapter

* CHANGELOG

---

Co-authored-by: ciampo <[email protected]>
Co-authored-by: DaniGuardiola <[email protected]>
Co-authored-by: tyxla <[email protected]>
  • Loading branch information
4 people authored and carstingaxion committed Jul 18, 2024
1 parent 1b36d06 commit 41caccf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
### Internal

- `CustomSelectControl`: switch to ariakit-based implementation ([#63258](https://github.com/WordPress/gutenberg/pull/63258)).
- `CustomSelectControl`: animate select popover appearance. ([#63343](https://github.com/WordPress/gutenberg/pull/63343))
- `CustomSelectControlV2`: animate select popover appearance. ([#63343](https://github.com/WordPress/gutenberg/pull/63343))
- `CustomSelectControlV2`: do not flip popover if legacy adapter. ([#63357](https://github.com/WordPress/gutenberg/pull/63357)).

### Enhancements

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@ function _CustomSelect(
sameWidth
slide={ false }
onKeyDown={ onSelectPopoverKeyDown }
// Match legacy behavior
flip={ ! isLegacy }
>
<CustomSelectContext.Provider value={ contextValue }>
{ children }
Expand Down

0 comments on commit 41caccf

Please sign in to comment.