Add missing aria-haspopup attribute to the buttons to set and replace…

… the featured image (WordPress#63360) * Add aria-haspopup attribute to featured image buttons. * Improve featured image button labeling. Co-authored-by: afercia <[email protected]> Co-authored-by: up1512001 <[email protected]> Co-authored-by: talldan <[email protected]>
carstingaxion · Jul 18, 2024 · 1b36d06 · 1b36d06
1 parent f0a9cd4
commit 1b36d06
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/editor/src/components/post-featured-image/index.js b/packages/editor/src/components/post-featured-image/index.js
@@ -170,13 +170,16 @@ function PostFeaturedImage( {
 									aria-label={
 										! featuredImageId
 											? null
-											: __( 'Edit or replace the image' )
+											: __(
+													'Edit or replace the featured image'
+											  )
 									}
 									aria-describedby={
 										! featuredImageId
 											? null
 											: `editor-post-featured-image-${ featuredImageId }-describedby`
 									}
+									aria-haspopup="dialog"
 								>
 									{ !! featuredImageId && media && (
 										<img
@@ -197,6 +200,7 @@ function PostFeaturedImage( {
 										<Button
 											className="editor-post-featured-image__action"
 											onClick={ open }
+											aria-haspopup="dialog"
 										>
 											{ __( 'Replace' ) }
 										</Button>