-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update sandpaper to 0.12.4, fix technical issues, replace HTML with MD where possible, fix typos #9
Conversation
…D where possible, fix typos
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/scientific-metadata/compare/md-outputs..md-outputs-PR-9 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-09-11 10:43:17 +0000 |
Updated `ìnstructor-guide.Rmd` (less HTML, more Markdown)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @apirogov. I reviewed your changes remotely and adjusted minor things in style.
As a result of the technical review I opened and commented on some issues with sandpaper:
This is just for the record, as we wanted to give feedback concerning the workbench (I think there were still some more things we wanted to report / suggest).
The lesson now successfully builds with latest sandpaper and I checked that the pages look still fine, the markup works, etc.
Still TODO: