-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated python 3.8 code and add missing __init__.py files #1053
Replace deprecated python 3.8 code and add missing __init__.py files #1053
Conversation
b5a1d17
to
3e2f7ee
Compare
@ttgamage I'm not sure what merge policy is here in place. When I clicked notification email about your approval, there was a button here to rebase this change on top of the latest changes so I clicked it, but it seems that you need to approve it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR definitely will be needed for later python version and for those it can be approved.
Some things on my mind:
- Are we sure that it also works with the current lower versions for backward compatibility, i.e. do these changes work with the current requirements.txt?
- The requirements.txt might need to be updated accordingly, or a second introduced for the later python versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with the requirements file and Python3.7
list(element)
also works in Python2 (which is not really compatible with the requirements given)
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ksuszka)
…for proper python module recognition
3e2f7ee
to
d6789eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ksuszka)
Nothing to add to the discussion, approved |
Description
srunner/osc2/__init__.py
file and fix a misspell insrunner/osc2/ast_manager/__init__.py
file name.Where has this been tested?
Possible Drawbacks
None.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)