Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated python 3.8 code and add missing __init__.py files #1053

Merged
merged 2 commits into from
May 3, 2024

Conversation

ksuszka
Copy link
Contributor

@ksuszka ksuszka commented Feb 14, 2024

Description

Where has this been tested?

  • Platform(s): Ubuntu 22.04
  • Python version(s): 3.10.12
  • Unreal Engine version(s): 4.26
  • CARLA version: 0.9.15

Possible Drawbacks

None.


This change is Reviewable

@ksuszka
Copy link
Contributor Author

ksuszka commented Mar 11, 2024

@ttgamage I'm not sure what merge policy is here in place. When I clicked notification email about your approval, there was a button here to rebase this change on top of the latest changes so I clicked it, but it seems that you need to approve it again.

Copy link
Contributor

@Daraan Daraan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR definitely will be needed for later python version and for those it can be approved.

Some things on my mind:

  • Are we sure that it also works with the current lower versions for backward compatibility, i.e. do these changes work with the current requirements.txt?
  • The requirements.txt might need to be updated accordingly, or a second introduced for the later python versions.

srunner/osc2/__init__.py Show resolved Hide resolved
Copy link
Contributor

@Daraan Daraan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: I tested with the requirements file and Python3.7

list(element) also works in Python2 (which is not really compatible with the requirements given)

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ksuszka)

Copy link
Contributor

@glopezdiest glopezdiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ksuszka)

@glopezdiest glopezdiest merged commit 4e780dc into carla-simulator:master May 3, 2024
1 of 4 checks passed
@glopezdiest
Copy link
Contributor

glopezdiest commented May 3, 2024

Nothing to add to the discussion, approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants