Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo binstall -V doesn't output version #485

Closed
mjpieters opened this issue Oct 16, 2022 · 1 comment · Fixed by #488
Closed

cargo binstall -V doesn't output version #485

mjpieters opened this issue Oct 16, 2022 · 1 comment · Fixed by #488
Assignees
Labels
Report: bug Something isn't working

Comments

@mjpieters
Copy link
Contributor

The -V flag doesn't appear to have any effect, other than tell me how quickly the command exited again:

% cargo binstall -V              
14:08:44 [INFO] Done in 5.051916ms

Nothing in the bin crate actually handles the version arg, nor will Clap do this as the option was disabled to avoid conflicting with --version.

@NobodyXu NobodyXu self-assigned this Oct 16, 2022
@NobodyXu NobodyXu added the Report: bug Something isn't working label Oct 16, 2022
@NobodyXu
Copy link
Member

Confirmed this behavior, I would fix it tomorrow.

NobodyXu added a commit that referenced this issue Oct 18, 2022

Verified

This commit was signed with the committer’s verified signature.
trxcllnt Paul Taylor
Fixed #485

* Make `Duration` in MainExit::Success` optional
* Fix arg parsing: Print version on `-V`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Report: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants