Skip to content

CIP-0137 | Fix protocol specifications #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

CIP-0137 | Fix protocol specifications #15

wants to merge 14 commits into from

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 1, 2025 •
edited
Loading

This PR includes updates of the CIP-0137:

  • The structure of the DMQ messages has evolved:
    • removed the blockNumber field
    • removed the ttl
    • added an expiresAt field (word32)
    • added a coldVerificationKey field (word32)
    • documented the message invalidation with expiresAt field
    • split the message payload from the KES signature and verification material
    • specified how to sign the message with the KES keys
  • The MsgServerDone message has been removed from the n2c local message notification mini-protocol
  • Some typos have been fixed.

(latest version of updated document)

@jpraynaud
Fix typos in n2c local message notification
712a3af
@jpraynaud
Replace 'blockNumber'/'TTL' fields with 'expiresAt'
ecda975 
In order to provide a simpler message invalidation mechanism.
@jpraynaud
Add an explicit field for cold verification key in the message
c0fcdfd 
The cold verification key is not strictly necessary in the operational certificate.
This allows to simplify the Haskell DMQ implementation and reuse the existing
KES signature verification of the Ouroboros consensus implementation.
@jpraynaud jpraynaud force-pushed the jpraynaud/update-cip-0137 branch from a529d6d to c0fcdfd Compare September 1, 2025 10:49
@jpraynaud jpraynaud marked this pull request as draft September 1, 2025 10:52
coot
coot approved these changes Sep 1, 2025
View reviewed changes
Copy link

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

coot
coot suggested changes Sep 1, 2025
View reviewed changes
@coot coot mentioned this pull request Sep 1, 2025
Closed
7 tasks
@jpraynaud jpraynaud force-pushed the jpraynaud/update-cip-0137 branch from 7760ff5 to f918f02 Compare September 1, 2025 14:33
coot
coot reviewed Sep 1, 2025
View reviewed changes
coot
coot reviewed Sep 1, 2025
View reviewed changes
@jpraynaud jpraynaud changed the title CIP-0137 | Fix messages specification CIP-0137 | Fix protocol specifications Sep 5, 2025
coot
coot suggested changes Sep 5, 2025
View reviewed changes
Copy link

@coot coot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should specify how the operational certificate is encoded.

coot
coot approved these changes Sep 8, 2025
View reviewed changes
Copy link

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jpraynaud, it looks good to me.

@jpraynaud jpraynaud mentioned this pull request Sep 8, 2025
Merged
@jpraynaud
Copy link
Member Author

jpraynaud commented Sep 9, 2025

Closing this PR which has been moved to cardano-foundation#1085

@jpraynaud jpraynaud closed this Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@coot coot coot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpraynaud @coot