-
Notifications
You must be signed in to change notification settings - Fork 371
CIP-0137 | Fix protocol specifications #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0137 | Fix protocol specifications #1085
Conversation
In order to provide a simpler message invalidation mechanism.
The cold verification key is not strictly necessary in the operational certificate. This allows to simplify the Haskell DMQ implementation and reuse the existing KES signature verification of the Ouroboros consensus implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpraynaud the text parts look understandable to me and I trust the specification changes are authoritative. Others with an interest in the evolution of this proposal, please feel free also to review: @coot @ch1bo @bolt12 @Quantumplation @perturbing
Marking Last Check for next meeting https://hackmd.io/@cip-editors/119 but can be merged earlier if other Network reviewer(s) + other editor(s) are also happy with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only read the changes and am not involved in the Mithril protocol design. It's great to see that new findings are contributed back to evolve the CIP, which I think is a good practice.
Left a comment though on the operationalCertificate which is treated less a black box now, but might demand some further clarification (for the CIP specification to be self contained).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR includes updates of the CIP-0137:
blockNumberfieldttlexpiresAtfield (word32)coldVerificationKeyfield (word32)expiresAtfieldMsgServerDonemessage has been removed from then2c local message notificationmini-protocol(latest version of updated document)