feat(core): resolve pr comments for eslint in core

.eslintrc.json

@@ -44,7 +44,10 @@
     "@typescript-eslint/no-duplicate-enum-values": "error",
     "@typescript-eslint/no-explicit-any": "warn",
     "@typescript-eslint/no-non-null-assertion": "warn",
-    "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }],
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      { "argsIgnorePattern": "^_" }
+    ],
     "react/no-unescaped-entities": 0,
     "react/react-in-jsx-scope": "off",
     "no-console": "error",

src/core/__fixtures__/agent/ipexCommunicationFixtures.ts

@@ -431,7 +431,9 @@ const multisigExnGrant = {
       d: "EE8_Xc0ZUh_sUJLtmBpVSEr-RFS2mRUIpFyL-pmvtPvx",
     },
   },
-  pathed: {},
+  pathed: {
+    exn: "d",
+  },
 };
 
 const credentialRecord = {

src/core/__fixtures__/agent/keriaNotificationFixtures.ts

@@ -269,7 +269,9 @@ const multisigExnGrant = {
       d: "EE8_Xc0ZUh_sUJLtmBpVSEr-RFS2mRUIpFyL-pmvtPvx",
     },
   },
-  pathed: {},
+  pathed: {
+    exn: "d",
+  },
 };
 
 const notificationMultisigRpyProp = {

src/core/__fixtures__/agent/multiSigFixtures.ts

@@ -1,4 +1,4 @@
-import { CreateIdentifierBody, Tier } from "signify-ts";
+import { CreateIdentifierBody, HabState, Tier } from "signify-ts";
 import { ConnectionStatus, CreationStatus } from "../../agent/agent.types";
 import {
   IdentifierMetadataRecord,
@@ -862,7 +862,7 @@ const linkedContacts = [
 
 const queuedIdentifier: QueuedGroupCreation & { initiator: true } = {
   name: "1.2.0.2:0:Identifier 2",
-  data: inceptionDataFix,
+  data: inceptionDataFix as CreateIdentifierBody & { group: HabState },
   initiator: true,
   groupConnections: linkedContacts,
   threshold: {

src/core/agent/agent.types.ts

@@ -120,15 +120,12 @@ interface ExnMessageA {
   };
   d?: string;
   r?: string;
-  exn?: {
-    r: string;
-    p: string;
-  };
+  exn?: unknown;
 }
 
 // Define types for the 'e' property in ExnMessage
 interface ExnMessageE {
-  acdc: {
+  acdc?: {
     d: string;
     i: string;
     s: string;
@@ -152,10 +149,7 @@ interface ExnMessageE {
   icp: {
     i: string;
   };
-  exn: {
-    r: string;
-    p: string;
-  };
+  exn: unknown;
   [key: string]: unknown;
 }
 
@@ -181,6 +175,13 @@ type ExnMessage = {
   };
 };
 
+// Type guard to check if ExnMessageE has acdc
+function exnHasAcdc(
+  e: ExnMessageE
+): e is ExnMessageE & { acdc: NonNullable<ExnMessageE["acdc"]> } {
+  return e.acdc !== undefined && e.acdc !== null;
+}
+
 type ConnectionNoteProps = Pick<ConnectionNoteDetails, "title" | "message">;
 
 interface ConnectionDetailsExtras {
@@ -264,13 +265,18 @@ export const OOBI_AGENT_ONLY_RE =
 export const DOOBI_RE = /^\/oobi\/(?<said>[^/]+)$/i;
 export const WOOBI_RE = /^\/\.well-known\/keri\/oobi\/(?<cid>[^/]+)$/;
 
+// Common error messages
+export const SIGNIFY_CLIENT_MANAGER_NOT_INITIALIZED =
+  "Signify client manager not initialized";
+
 export {
   ConnectionStatus,
   MiscRecordId,
   OobiType,
   CreationStatus,
   isRegularConnectionDetails,
   isMultisigConnectionDetails,
+  exnHasAcdc,
 };
 
 export type {

src/core/agent/services/connectionService.test.ts

@@ -1911,7 +1911,7 @@ describe("Connection service of agent", () => {
     });
     expect(result.historyItems).toHaveLength(2);
     expect(
-      result.historyItems?.some(
+      result.historyItems.some(
         (item) => item.type === ConnectionHistoryType.IPEX_AGREE_COMPLETE
       )
     ).toBe(true);
@@ -1991,7 +1991,7 @@ describe("Connection service of agent", () => {
     });
     expect(result.historyItems).toHaveLength(1);
     expect(
-      result.historyItems?.some(
+      result.historyItems.some(
         (item) => item.type === ConnectionHistoryType.IPEX_AGREE_COMPLETE
       )
     ).toBe(false);

src/core/agent/services/connectionService.ts

@@ -258,18 +258,22 @@ class ConnectionService extends AgentService {
       }
       const contact = contactRecordMap.get(connectionPair.contactId);
 
-      if (contact?.alias && contact?.oobi) {
-        connections.push({
-          id: connectionPair.contactId,
-          alias: contact.alias,
-          createdAt: connectionPair.createdAt,
-          oobi: contact.oobi,
-          groupId: contact.groupId,
-          creationStatus: connectionPair.creationStatus,
-          pendingDeletion: connectionPair.pendingDeletion,
-          identifier: connectionPair.identifier, // Include identifier from connection pair
-        });
+      if (!contact) {
+        throw new Error(
+          `Contact missing from map for contactId: ${connectionPair.contactId}`
+        );
       }
+
+      connections.push({
+        id: connectionPair.contactId,
+        alias: contact.alias,
+        createdAt: connectionPair.createdAt,
+        oobi: contact.oobi,
+        groupId: contact.groupId,
+        creationStatus: connectionPair.creationStatus,
+        pendingDeletion: connectionPair.pendingDeletion,
+        identifier: connectionPair.identifier, // Include identifier from connection pair
+      });
     }
 
     return connections.map((connection) =>
@@ -312,17 +316,24 @@ class ConnectionService extends AgentService {
       status = ConnectionStatus.FAILED;
     }
 
-    return {
+    const baseDetails = {
       id: record.id,
       label: record.alias,
       createdAtUTC: record.createdAt.toISOString(),
       status,
       oobi: record.oobi,
       contactId: record.id,
-      ...(record.groupId
-        ? { groupId: record.groupId }
-        : { identifier: record.identifier || "" }),
     };
+
+    if (record.groupId !== undefined) {
+      return { ...baseDetails, groupId: record.groupId };
+    }
+
+    if (!record.identifier) {
+      throw new Error(`Regular contact must have identifier: ${record.id}`);
+    }
+
+    return { ...baseDetails, identifier: record.identifier };
   }
 
   async getConnectionById(

src/core/agent/services/credentialService.types.ts

@@ -8,6 +8,20 @@ enum CredentialStatus {
 
 type CredentialShortDetails = Omit<CredentialMetadataRecordProps, "createdAt">;
 
+interface ACDC {
+  v: string;
+  d: string;
+  i: string;
+  ri: string;
+  s: string;
+  a: {
+    d: string;
+    i: string;
+    dt: string;
+    [key: string]: unknown;
+  };
+}
+
 interface ACDCDetails
   extends Omit<CredentialShortDetails, "credentialType" | "issuanceDate"> {
   i: string;
@@ -45,4 +59,4 @@ interface KeriaCredential {
 }
 
 export { CredentialStatus };
-export type { CredentialShortDetails, ACDCDetails, KeriaCredential };
+export type { CredentialShortDetails, ACDCDetails, KeriaCredential, ACDC };

src/core/agent/services/identifier.types.ts

@@ -1,4 +1,4 @@
-import { CreateIdentifierBody } from "signify-ts";
+import { CreateIdentifierBody, HabState } from "signify-ts";
 import {
   MultisigConnectionDetails,
   CreationStatus,
@@ -61,29 +61,45 @@ enum IdentifierType {
   Group = "group",
 }
 
-type QueuedIdentifierCreation = {
-  name: string;
-  data: CreateIdentifierBody;
-};
-
 interface MultisigThresholds {
   signingThreshold: number;
   rotationThreshold: number;
 }
 
-type QueuedGroupProps =
+// Discriminated union with proper type safety for group data
+type QueuedGroupCreation =
   | {
       initiator: true;
+      name: string;
+      data: CreateIdentifierBody & { group: HabState };
       groupConnections: MultisigConnectionDetails[];
       threshold: number | MultisigThresholds;
     }
   | {
       initiator: false;
+      name: string;
+      data: CreateIdentifierBody;
       notificationId: string;
       notificationSaid: string;
     };
 
-type QueuedGroupCreation = QueuedIdentifierCreation & QueuedGroupProps;
+// Legacy type for backward compatibility if needed elsewhere
+type QueuedIdentifierCreation = {
+  name: string;
+  data: CreateIdentifierBody;
+};
+
+type QueuedGroupProps =
+  | {
+      initiator: true;
+      groupConnections: MultisigConnectionDetails[];
+      threshold: number | MultisigThresholds;
+    }
+  | {
+      initiator: false;
+      notificationId: string;
+      notificationSaid: string;
+    };
 
 interface GroupParticipants {
   ourIdentifier: IdentifierMetadataRecord;
@@ -110,17 +126,15 @@ interface RemoteSignRequest {
   payload: JSONObject;
 }
 
+export { IdentifierType };
+
 export type {
   IdentifierShortDetails,
   IdentifierDetails,
   MultiSigIcpRequestDetails,
   CreateIdentifierInputs,
   CreateIdentifierResult,
   MultisigThresholds,
-};
-
-export { IdentifierType };
-export type {
   GroupMetadata,
   QueuedIdentifierCreation,
   QueuedGroupProps,

src/core/agent/services/identifierService.ts

@@ -230,6 +230,10 @@ class IdentifierService extends AgentService {
     metadata: Omit<IdentifierMetadataRecordProps, "id" | "createdAt">,
     backgroundTask = false
   ): Promise<CreateIdentifierResult> {
+    if (!this.props.signifyClient.agent) {
+      throw new Error("Agent not initialized");
+    }
+
     const { toad, witnesses } = await this.getAvailableWitnesses();
 
     if (!UI_THEMES.includes(metadata.theme)) {
@@ -303,9 +307,6 @@ class IdentifierService extends AgentService {
       .identifiers()
       .get(identifier)) as HabState;
 
-    if (!this.props.signifyClient.agent) {
-      throw new Error("Agent not initialized");
-    }
     const addRoleOperation = await this.props.signifyClient
       .identifiers()
       .addEndRole(identifier, "agent", this.props.signifyClient.agent.pre);
@@ -658,16 +659,7 @@ class IdentifierService extends AgentService {
   }
 
   async syncKeriaIdentifiers(): Promise<void> {
-    const cloudIdentifiers: Array<{
-      prefix: string;
-      name: string;
-      group?: {
-        mhab: {
-          name: string;
-          prefix: string;
-        };
-      };
-    }> = [];
+    const cloudIdentifiers: HabState[] = [];
     let returned = -1;
     let iteration = 0;
 
@@ -683,8 +675,10 @@ class IdentifierService extends AgentService {
 
     const localIdentifiers = await this.identifierStorage.getAllIdentifiers();
 
-    const unSyncedDataWithGroup = [];
-    const unSyncedDataWithoutGroup = [];
+    const unSyncedDataWithGroup: (HabState & {
+      group: NonNullable<HabState["group"]>;
+    })[] = [];
+    const unSyncedDataWithoutGroup: HabState[] = [];
     for (const identifier of cloudIdentifiers) {
       if (localIdentifiers.find((item) => item.id === identifier.prefix)) {
         continue;
@@ -693,7 +687,9 @@ class IdentifierService extends AgentService {
       if (identifier.group === undefined) {
         unSyncedDataWithoutGroup.push(identifier);
       } else {
-        unSyncedDataWithGroup.push(identifier);
+        unSyncedDataWithGroup.push(
+          identifier as HabState & { group: NonNullable<HabState["group"]> }
+        );
       }
     }
 
@@ -762,9 +758,6 @@ class IdentifierService extends AgentService {
         .identifiers()
         .get(identifier.prefix)) as HabState;
 
-      if (!identifier.group) {
-        throw new Error("Group identifier missing group data");
-      }
       const nameToParse = identifier.name.startsWith(
         IdentifierService.DELETED_IDENTIFIER_THEME
       )