feat(core): resolve pr comments for eslint in core #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is this ready for review? |
…aIdentifiers method
…and improve typing for grant exn structure
…xCommunicationService methods
…s not found in KeriaNotificationService
…ialization across services
…prove type safety
…s to enhance type safety
Sotatek-DucPhung
force-pushed
the
feat/VT20-2117-resolve-PR-comments-for-eslint-in-core
branch
from
0b37254 to
e045043
Compare
…ling across services
…nd add type guard in KeriaNotificationService
…es in IpexCommunicationService and KeriaNotificationService
…data handling in MultiSigService
…ervice by refining type assertions
Collaborator
Author
|
@iFergal please take a look again |
iFergal
reviewed
Nov 3, 2025
src/ui/pages/NotificationDetails/components/CredentialRequest/CredentialRequest.tsx
Outdated
Show resolved
Hide resolved
…Lite migration by refining type definitions
…tionService and CredentialRequest component
iFergal
reviewed
Nov 4, 2025
iFergal
changed the title
iFergal
deleted the
feat/VT20-2117-resolve-PR-comments-for-eslint-in-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve PR comments for ESLint in core
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Design Review