Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ApiCoinSelectionInput type with ApiWalletInput. #3012

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Replace ApiCoinSelectionInput type with ApiWalletInput. #3012

merged 1 commit into from
Nov 10, 2021

Conversation

jonathanknowles
Copy link
Contributor

These types are identical, and their serialized forms are also identical.

@jonathanknowles
Replace ApiCoinSelectionInput type with ApiWalletInput.
c877522 
These types are identical, and their serialized forms are also
identical.
@jonathanknowles jonathanknowles mentioned this pull request Nov 10, 2021
Merged
1 task
paweljakubas
paweljakubas approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree here ApiCoinSelectionInput and ApiWalletInput are the same

@jonathanknowles jonathanknowles marked this pull request as ready for review November 10, 2021 09:03
@jonathanknowles jonathanknowles self-assigned this Nov 10, 2021
@jonathanknowles
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 10, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 4d98ff1 into master Nov 10, 2021
@iohk-bors iohk-bors bot deleted the jonathanknowles/merge-api-input-types branch November 10, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

Assignees

@jonathanknowles jonathanknowles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanknowles @paweljakubas