Fix construct tx #3010
Merged
Fix construct tx #3010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@piotr-iohk please verify if with this fix the problems (both adp-1256 and adp-1202) vanish. Thanks! |
piotr-iohk
reviewed
Nov 9, 2021
| Just (ApiPaymentAddresses content) -> | ||
| pure $ F.toList (addressAmountToTxOut <$> content) | ||
| Just (ApiPaymentAll _) -> do | ||
| liftHandler $ throwE $ ErrConstructTxNotImplemented "ADP-909" |
There was a problem hiding this comment.
ADP-909 is already closed... is it a message that's potentially displayed to the user? If so it needs to be reworded 😅
piotr-iohk
pushed a commit
that referenced
this pull request
Nov 9, 2021
piotr-iohk
pushed a commit
that referenced
this pull request
Nov 9, 2021
| path' == path'' && | ||
| amt' == amt'' && | ||
| assets' == assets'' | ||
| testEquality _ _ = False |
There was a problem hiding this comment.
Perhaps we could replace this testEquality function with == if we merge the ApiCoinSelectionInput and ApiWalletInput types. See #3012
There was a problem hiding this comment.
indeed, we can simplify considerably this checking for equality - did it in last two commits
paweljakubas
force-pushed
the
paweljakubas/adp-1256/fix-construct-tx
branch
from
5222e33 to
1b7bb29
Compare
paweljakubas
force-pushed
the
paweljakubas/adp-1256/fix-construct-tx
branch
from
c82f81c to
5d29520
Compare
jonathanknowles
approved these changes
Nov 15, 2021
Comment on lines
2127
to
2130
| , utxoAvailableForInputs = | ||
| UTxOSelection.fromIndex utxoAvailable | ||
| , utxoAvailableForCollateral = | ||
| UTxOIndex.toUTxO utxoAvailable |
There was a problem hiding this comment.
Suggested change
| , utxoAvailableForInputs = | |
| UTxOSelection.fromIndex utxoAvailable | |
| , utxoAvailableForCollateral = | |
| UTxOIndex.toUTxO utxoAvailable | |
| , utxoAvailableForInputs = | |
| UTxOSelection.fromIndex utxoAvailable | |
| , utxoAvailableForCollateral = | |
| UTxOIndex.toUTxO utxoAvailable |
Comment on lines
+2143
to
+2150
| sel <- liftHandler $ | ||
| W.assignChangeAddressesWithoutDbUpdate wrk wid genChange utx |
There was a problem hiding this comment.
Suggested change
| sel <- liftHandler $ | |
| W.assignChangeAddressesWithoutDbUpdate wrk wid genChange utx | |
| sel <- liftHandler $ | |
| W.assignChangeAddressesWithoutDbUpdate wrk wid genChange utx |
| (Link.decodeTransaction @'Shelley wa) Default decodePayload | ||
| let decodedInputs = getFromResponse #inputs rDecodedTxSource | ||
|
|
||
| WalletInput <$> expectedInputs `shouldBe` decodedInputs |
Comment on lines
2113
to
2114
| ( W.assignChangeAddresses genChange sel s | ||
| & uncurry (W.selectionToUnsignedTx (txWithdrawal txCtx)) |
There was a problem hiding this comment.
Suggested change
| ( W.assignChangeAddresses genChange sel s | |
| & uncurry (W.selectionToUnsignedTx (txWithdrawal txCtx)) | |
| ( W.assignChangeAddresses genChange sel s | |
| & uncurry (W.selectionToUnsignedTx (txWithdrawal txCtx)) |
address rebase ommision
paweljakubas
force-pushed
the
paweljakubas/adp-1256/fix-construct-tx
branch
from
18d2460 to
53388ff
Compare
|
bors r+ |
1 similar comment
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adp-1256
adp-1202 (possibly)
Comments
Issue Number