Add Nix expressions required to use newest fmt library #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,7 +103,7 @@ | |||
| }; | |||
| exes = { | |||
| "haskell-language-server" = { | |||
| depends = ((((((((((((((([ | |||
| depends = (((((((((((((((((([ | |||
jonathanknowles
approved these changes
Oct 5, 2021
Base automatically changed from
jonathanknowles/adp-1037/test-coin-selection-preparation
to
master
October 5, 2021 07:09
|
The "Stack Rebuild" item in buildkite fails with This prevents merging, I suppose? No idea what's going on, but @rvl mentioned an issue similar to this in our internal nix-best-practices channel. This "GLIBC_2.33 issue" also prevents the update to GHC 8.10.7 in #2937 |
sevanspowell
force-pushed
the
sevanspowell/adp-1037/fmt-library-nix-support
branch
from
6c8ac91 to
4840ce0
Compare
- We want to update to the newest fmt library (fmt-6.3.0) to make use of new Buildable instances. - Ran `niv update haskell.nix` to get latest hackage.nix, which provides us with the Nix expressions for fmt-6.3.0. - There is some build issue with haskell-language-server-1.2.0.0 and the version of haskell.nix we've pinned, so update haskell-language-server to 1.4.0.0. - Update the index-state so we can build it. - `./nix/regenerate.sh`: regenerate the materialized files
- This is to overcome the following error when building cardano-config, a
dependency:
```
src/Cardano/Config/Git/Rev.hs:33:35: error:
• Exception when trying to run compile-time code:
git: readCreateProcessWithExitCode: posix_spawnp: failed (Undefined error: 0)
Code: gitRevFromGit
• In the untyped splice: $(gitRevFromGit)
|
33 | fromGit = T.strip (T.pack $(gitRevFromGit))
```
That is, the Template Haskell was failing to compile because it did not have git
in PATH.
- Note the repeated "buildPackages" attr. This snippet was provided by Hamish
Mackenzie, who said that it's "because git had (think it still might) a
dependency on python and that depended on gdb and as a result when cross
compiling buildPackages.git and buildPackages.buildPackages.git were subtly
different (causing cache misses). I am not sure if it is a problem with
gitMinimal but it might be."
sevanspowell
force-pushed
the
sevanspowell/adp-1037/fmt-library-nix-support
branch
from
c826455 to
ced95e1
Compare
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
sevanspowell/adp-1037/fmt-library-nix-support
branch
This was referenced Oct 21, 2021
iohk-bors bot
added a commit
that referenced
this pull request
Oct 21, 2021
2833: nix: Take GHC version and index-state from cabal.project r=rvl a=rvl - ~Bumps Haskell.nix to latest master. This includes input-output-hk/haskell.nix#1200, which patches Cabal to fix bugs which made the solver excessively slow.~ ⇒ PR #2947 - `.gitignore` tweak to make it more specific - don't ask. - nix: Take GHC version and index-state from `cabal.project` - Use more of `nix-shell --pure` for buildkite. ### Issue Number #2812 2983: Enable more tests for construct ep r=piotr-iohk a=piotr-iohk - bcf78bf Enable remaining construct ep integration tests (where applicable) - df75842 Make signTx DSL useful also in balance -> sign -> submit workflow - 4e26f5d Update swagger to reflect current state of affairs, in particular removing Byron Transactions New altogether from displaying on rendered api doc - d80d6b6 Use expectedFee returned by construct ep rather than explicit value ### Comments Wanted to add more tests for balance ep, but noticed first that few tests for construct can be enabled. Also updated swagger so it reflects current state more accurately. ### Issue Number sort of ADP-1223 Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
niv update haskell.nixto get latest hackage.nix, which provides us with the Nix expressions for fmt-6.3.0../nix/regenerate.sh: regenerate the materialized files