Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more tests for construct ep #2983

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Oct 20, 2021

  • bcf78bf
    Enable remaining construct ep integration tests (where applicable)

  • df75842
    Make signTx DSL useful also in balance -> sign -> submit workflow

  • 4e26f5d
    Update swagger to reflect current state of affairs, in particular removing Byron Transactions New altogether from displaying on rendered api doc

  • d80d6b6
    Use expectedFee returned by construct ep rather than explicit value

Comments

Wanted to add more tests for balance ep, but noticed first that few tests for construct can be enabled.
Also updated swagger so it reflects current state more accurately.

Issue Number

sort of ADP-1223

@piotr-iohk piotr-iohk self-assigned this Oct 20, 2021
@piotr-iohk piotr-iohk force-pushed the piotr/balance-integration-tests branch from 6ee824b to d80d6b6 Compare October 20, 2021 18:56
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@piotr-iohk
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 21, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit a08d46f into master Oct 21, 2021
@iohk-bors iohk-bors bot deleted the piotr/balance-integration-tests branch October 21, 2021 12:16
WilliamKingNoel-Bot pushed a commit that referenced this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants