Test that coin selections do not have fees that are excessively high. #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, this commit uses `selectionMaximumCost` within the `selectionHasValidSurplus` function, which is used by the property test suite to verify that every single generated selection is valid.
jonathanknowles
changed the title
selectionMaximumCost to CoinSelection.Balance.
sevanspowell
approved these changes
Sep 30, 2021
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1037/selection-maximum-cost
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1037
Summary
This PR provides a safety mechanism to ensure that selections produced by
CoinSelection.Balancedo not have fees that are excessively high.Details
This PR:
selectionMaximumCostfunction, which is defined in terms ofselectionMinimumCost.selectionMaximumCostwithin theselectionHasValidSurplusfunction, which in turn is used within property tests to verify every single generated selection.