Add minimumCollateralPercentage to ProtocolParameters.
#2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
force-pushed
the
jonathanknowles/adp-1116/minimum-collateral-percentage
branch
from
1bc2e6a to
b49d57c
Compare
This commit adds the `minimumCollateralPercentage` field to the `SelectionConstraints` record type of `CoinSelection`, and populates the field with the protocol parameter in `Cardano.Wallet`.
sevanspowell
approved these changes
Sep 30, 2021
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jonathanknowles/adp-1116/minimum-collateral-percentage
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1166
Summary
This PR:
minimumCollateralPercentagefield to theProtocolParameterstype, and exposes this parameter in the API.minimumCollateralPercentagefield to theCoinSelection.SelectionConstraintstype, and populates it inWallet.selectAssets.Notes
This PR does not use our internal
Percentagetype, since:Percentagetype has amaxBoundthat corresponds to100%, but theminimumCollateralPercentageprotocol parameter has no such upper bound.Percentagetype makes it possible to encode fractions of a percent, but theminimumCollateralPercentageprotocol parameter only allows whole percentage points (it's a natural number).