Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of --skip in buildkite builds #2832

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Fix usage of --skip in buildkite builds #2832

merged 1 commit into from
Aug 19, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Aug 18, 2021 •
edited
Loading

  • Call --skip "integration" instead of --skip cardano-wallet:integration. The latter is ineffective.
  • Confirm that the behaviour in CI indeed looks ok.
    • Integration tests are skipped in normal builds
    • Integration tests in Mary are run from bors
    • Integration tests in Alonzo are run from bors

Issue Number

None. Follow-up to #2810 .

Comments

@Anviking
Fix usage of --skip in buildkite builds
6d2a5db 
To ensure we actually don't run integration tests in buildkite PR builds,
except from bors.

> stack test cardano-wallet:integration --skip integration
runs nothing

whereas
> stack test cardano-wallet:integration --skip cardano-wallet:integration
runs the integration tests.
@Anviking Anviking self-assigned this Aug 18, 2021
@Anviking Anviking requested a review from rvl August 18, 2021 17:14
@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Aug 18, 2021
@iohk-bors
Try #2832:
ef69bab
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 18, 2021

try

Build succeeded:

rvl
rvl approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@rvl
Copy link
Contributor

rvl commented Aug 19, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 19, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 06404a1 into master Aug 19, 2021
@iohk-bors iohk-bors bot deleted the anviking/buildkite-fixes branch August 19, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @rvl