Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildkite fixes #2810

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Buildkite fixes #2810

merged 2 commits into from
Aug 10, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Aug 9, 2021

Issue Number

Found during ADP-1062.

Overview

rvl added 2 commits August 9, 2021 16:58
@rvl rvl requested a review from Anviking August 9, 2021 14:17
@rvl rvl self-assigned this Aug 9, 2021
Anviking
Anviking approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve display of section headers in logs

👍

Don't run integration tests on every PR (caused by

👌 lgtm

@Anviking
Copy link
Member

Anviking commented Aug 9, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 9, 2021
@iohk-bors @rvl
Merge #2810
ded263f 
2810: Buildkite fixes r=Anviking a=rvl

### Issue Number

Found during ADP-1062.

### Overview

- Improve display of section headers in logs
- Don't run integration tests on every PR (caused by #2789)


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 9, 2021 •
edited by rvl
Loading

Build failed:

--  While building package byron-spec-ledger-0.1.0.0 (scroll up to its section to see the error) using:
--
  | /build/cardano-wallet.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_3.2.1.0_ghc-8.10.5 --builddir=.stack-work/dist/x86_64-linux/Cabal-3.2.1.0 build --ghc-options " -fdiagnostics-color=always"
  | Process exited with code: ExitFailure 1
  | error: Command exited with code 1!
  | Continuing...

#2812

stack cache issue from dependency bump

@Anviking
Copy link
Member

Anviking commented Aug 9, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 9, 2021 •
edited by rvl
Loading

Build failed:

#2812 again

@rvl rvl merged commit 2fa3f9a into master Aug 10, 2021
@rvl rvl deleted the rvl/adp-1062/buildkite-fixes branch August 10, 2021 04:40
@Anviking Anviking mentioned this pull request Aug 18, 2021
Merged
5 tasks
iohk-bors bot added a commit that referenced this pull request Aug 19, 2021
@iohk-bors @Anviking
Merge #2832
06404a1 
2832: Fix usage of --skip in buildkite builds r=rvl a=Anviking


- [x] Call `--skip "integration"` instead of `--skip cardano-wallet:integration`. The latter is ineffective.
- [x] Confirm that the behaviour in CI indeed looks ok.
    - [x] Integration tests are skipped in normal builds
    - [x] Integration tests in Mary are run from bors
    - [x] Integration tests in Alonzo are run from bors

### Issue Number

None. Follow-up to #2810 .

<!-- Put here a reference to the issue that this PR relates to and which requirements it tackles. Jira issues of the form ADP- will be auto-linked. -->

### Comments

<!-- Additional comments or screenshots to attach if any -->


Co-authored-by: Johannes Lund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

Assignees

@rvl rvl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvl @Anviking