Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to cardano-node alonzo-purple-1.0.1 #2811

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Aug 9, 2021

Issue Number

ADP-1066

Overview

  • I have bumped to cardano-node alonzo-purple-1.0.1

Comments

input-output-hk/cardano-haskell#55

@Anviking
Copy link
Member Author

Anviking commented Aug 9, 2021

bors try

iohk-bors bot added a commit that referenced this pull request Aug 9, 2021
@Anviking Anviking self-assigned this Aug 9, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 9, 2021

try

Build failed:

 test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs:621:9:
  1) Cardano.Wallet.Shelley.Transaction, estimateMaxNumberOfInputs for ShelleyKey, bigger size  ==> more inputs
       Timeout of 300000 microseconds exceeded. (after 333 tests):
         Quantity 1632
         [TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}},TxOut {address = Address "\SOH\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL\NUL", tokens = TokenBundle {coin = Coin 0, tokens = TokenMap (fromList [])}}]

  To rerun use: --match "/Cardano.Wallet.Shelley.Transaction/estimateMaxNumberOfInputs for ShelleyKey/bigger size  ==> more inputs/"

Randomized with seed 1508953711

Finished in 31.5074 seconds, used 22.2646 seconds of CPU time
162 examples, 1 failure

Slow spec items:
  test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs:194:9: /Cardano.Wallet.Shelley.Transaction/decodeSignedTx testing/roundtrip for Shelley witnesses/ (8497ms)
  test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs:198:9: /Cardano.Wallet.Shelley.Transaction/decodeSignedTx testing/roundtrip for Byron witnesses/ (7423ms)
  test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs:196:9: /Cardano.Wallet.Shelley.Transaction/decodeSignedTx testing/roundtrip for Shelley witnesses Allegra/ (6945ms)
  test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs:621:9: /Cardano.Wallet.Shelley.Transaction/estimateMaxNumberOfInputs for ShelleyKey/bigger size  ==> more inputs/ (758ms)
  test/unit/Cardano/Wallet/Shelley/TransactionSpec.hs:291:9: /Cardano.Wallet.Shelley.Transaction/fee calculations/scripts incur fees/ (680ms)
  test/unit/Cardano/Wallet/Shelley/CompatibilitySpec.hs:182:9: /Cardano.Wallet.Shelley.Compatibility/Shelley Addresses/(Mainnet) can be deserialised by shelley ledger spec/ (652ms)
  test/unit/Cardano/Wallet/Shelley/CompatibilitySpec.hs:199:9: /Cardano.Wallet.Shelley.Compatibility/Shelley Addresses/Shelley addresses from bech32 - testnet/ (605ms)
  test/unit/Cardano/Wallet/Shelley/CompatibilitySpec.hs:261:9: /Cardano.Wallet.Shelley.Compatibility/Assessing the sizes of token bundles/unit_assessTokenBundleSize_fixedSizeBundle_128/ (553ms)
  test/unit/Cardano/Wallet/Shelley/CompatibilitySpec.hs:188:9: /Cardano.Wallet.Shelley.Compatibility/Shelley Addresses/Shelley addresses from base16, bech32 and base58/ (539ms)
  test/unit/Cardano/Wallet/Shelley/Compatibility/LedgerSpec.hs:102:9: /Cardano.Wallet.Shelley.Compatibility.Ledger/Cardano.Wallet.Shelley.Compatibility.LedgerSpec/Unit tests for computeMinimumAdaQuantity/unit_computeMinimumAdaQuantity_fixedSizeBundle_256/ (456ms)
builder for '/nix/store/4mhr7gzrxaz1gdj40vk2dz17ya931fy1-cardano-wallet-test-unit-2021.7.30-check.drv' failed with exit code 1

@Anviking
Copy link
Member Author

I re-added the --cache /dev/null to prevent fix the nix regenerate issue.

The other failures simply look like known flaky ones.

bors try

iohk-bors bot added a commit that referenced this pull request Aug 10, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 10, 2021

try

Build succeeded:

@rvl rvl force-pushed the anviking/ADP-1066/alonzo-purple-1.0.1 branch from 5f30e1a to 4c906e7 Compare August 10, 2021 11:48
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anviking Anviking force-pushed the anviking/ADP-1066/alonzo-purple-1.0.1 branch from 4c906e7 to cf1240f Compare August 10, 2021 12:34
@Anviking
Copy link
Member Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 10, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit 23b9331 into master Aug 10, 2021
@iohk-bors iohk-bors bot deleted the anviking/ADP-1066/alonzo-purple-1.0.1 branch August 10, 2021 14:39
iohk-bors bot added a commit that referenced this pull request Aug 10, 2021
2798: Remove unused Arbitrary instance r=jonathanknowles a=sevanspowell

## Overview

- Removed an Arbitrary instance that isn't used.


2807: Identify UTxOs suitable for use as collateral r=jonathanknowles a=sevanspowell

# Issue Number

ADP-1053


# Overview

- Added a function `asCollateral` to identify UTxOs suitable as collateral inputs.
- Clarified the meaning of a "VK input".
- Thoroughly tested the collateral functions.
- Added a property test to test the behaviour of `TokenBundle.toCoin`.

# Comments
[
I've clarified with the ledger team](https://input-output-rnd.slack.com/archives/CCRB7BU8Y/p1628060541075300) that a UTxO is to be considered suitable for collateral iff the payment credential associated with the output address of the UTxO is of type "key hash".

See the "Binary Address Format" heading of this spec: https://hydra.iohk.io/build/6752483/download/1/ledger-spec.pdf


2816: Bump version to v2021-08-11 r=Anviking a=Anviking

- [x] Bump wallet version to v2021-08-10 in preparation for release

### Issue Number

Release.

### Comments

Dependent on #2811 

<!-- Additional comments or screenshots to attach if any -->


Co-authored-by: Samuel Evans-Powell <[email protected]>
Co-authored-by: Jonathan Knowles <[email protected]>
Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this pull request Aug 10, 2021
2798: Remove unused Arbitrary instance r=jonathanknowles a=sevanspowell

## Overview

- Removed an Arbitrary instance that isn't used.


2807: Identify UTxOs suitable for use as collateral r=jonathanknowles a=sevanspowell

# Issue Number

ADP-1053


# Overview

- Added a function `asCollateral` to identify UTxOs suitable as collateral inputs.
- Clarified the meaning of a "VK input".
- Thoroughly tested the collateral functions.
- Added a property test to test the behaviour of `TokenBundle.toCoin`.

# Comments
[
I've clarified with the ledger team](https://input-output-rnd.slack.com/archives/CCRB7BU8Y/p1628060541075300) that a UTxO is to be considered suitable for collateral iff the payment credential associated with the output address of the UTxO is of type "key hash".

See the "Binary Address Format" heading of this spec: https://hydra.iohk.io/build/6752483/download/1/ledger-spec.pdf


2816: Bump version to v2021-08-11 r=Anviking a=Anviking

- [x] Bump wallet version to v2021-08-10 in preparation for release

### Issue Number

Release.

### Comments

Dependent on #2811 

<!-- Additional comments or screenshots to attach if any -->


Co-authored-by: Samuel Evans-Powell <[email protected]>
Co-authored-by: Jonathan Knowles <[email protected]>
Co-authored-by: Johannes Lund <[email protected]>
iohk-bors bot added a commit that referenced this pull request Aug 10, 2021
2798: Remove unused Arbitrary instance r=jonathanknowles a=sevanspowell

## Overview

- Removed an Arbitrary instance that isn't used.


2807: Identify UTxOs suitable for use as collateral r=jonathanknowles a=sevanspowell

# Issue Number

ADP-1053


# Overview

- Added a function `asCollateral` to identify UTxOs suitable as collateral inputs.
- Clarified the meaning of a "VK input".
- Thoroughly tested the collateral functions.
- Added a property test to test the behaviour of `TokenBundle.toCoin`.

# Comments
[
I've clarified with the ledger team](https://input-output-rnd.slack.com/archives/CCRB7BU8Y/p1628060541075300) that a UTxO is to be considered suitable for collateral iff the payment credential associated with the output address of the UTxO is of type "key hash".

See the "Binary Address Format" heading of this spec: https://hydra.iohk.io/build/6752483/download/1/ledger-spec.pdf


2816: Bump version to v2021-08-11 r=Anviking a=Anviking

- [x] Bump wallet version to v2021-08-10 in preparation for release

### Issue Number

Release.

### Comments

Dependent on #2811 

<!-- Additional comments or screenshots to attach if any -->


Co-authored-by: Samuel Evans-Powell <[email protected]>
Co-authored-by: Jonathan Knowles <[email protected]>
Co-authored-by: Johannes Lund <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants