Remove unused Arbitrary instance #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
approved these changes
Aug 3, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 10, 2021
2798: Remove unused Arbitrary instance r=jonathanknowles a=sevanspowell ## Overview - Removed an Arbitrary instance that isn't used. 2807: Identify UTxOs suitable for use as collateral r=jonathanknowles a=sevanspowell # Issue Number ADP-1053 # Overview - Added a function `asCollateral` to identify UTxOs suitable as collateral inputs. - Clarified the meaning of a "VK input". - Thoroughly tested the collateral functions. - Added a property test to test the behaviour of `TokenBundle.toCoin`. # Comments [ I've clarified with the ledger team](https://input-output-rnd.slack.com/archives/CCRB7BU8Y/p1628060541075300) that a UTxO is to be considered suitable for collateral iff the payment credential associated with the output address of the UTxO is of type "key hash". See the "Binary Address Format" heading of this spec: https://hydra.iohk.io/build/6752483/download/1/ledger-spec.pdf 2816: Bump version to v2021-08-11 r=Anviking a=Anviking - [x] Bump wallet version to v2021-08-10 in preparation for release ### Issue Number Release. ### Comments Dependent on #2811 <!-- Additional comments or screenshots to attach if any --> Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]> Co-authored-by: Johannes Lund <[email protected]>
|
This PR was included in a batch that was canceled, it will be automatically retried |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 10, 2021
2798: Remove unused Arbitrary instance r=jonathanknowles a=sevanspowell ## Overview - Removed an Arbitrary instance that isn't used. 2807: Identify UTxOs suitable for use as collateral r=jonathanknowles a=sevanspowell # Issue Number ADP-1053 # Overview - Added a function `asCollateral` to identify UTxOs suitable as collateral inputs. - Clarified the meaning of a "VK input". - Thoroughly tested the collateral functions. - Added a property test to test the behaviour of `TokenBundle.toCoin`. # Comments [ I've clarified with the ledger team](https://input-output-rnd.slack.com/archives/CCRB7BU8Y/p1628060541075300) that a UTxO is to be considered suitable for collateral iff the payment credential associated with the output address of the UTxO is of type "key hash". See the "Binary Address Format" heading of this spec: https://hydra.iohk.io/build/6752483/download/1/ledger-spec.pdf 2816: Bump version to v2021-08-11 r=Anviking a=Anviking - [x] Bump wallet version to v2021-08-10 in preparation for release ### Issue Number Release. ### Comments Dependent on #2811 <!-- Additional comments or screenshots to attach if any --> Co-authored-by: Samuel Evans-Powell <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]> Co-authored-by: Johannes Lund <[email protected]>
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview