Use LineBuffering in unit tests #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use it in the integration tests. Maybe it will improve the unit timeouts or our understanding of it - could be worth a shot.
rvl
approved these changes
Jun 17, 2021
rvl
approved these changes
Jun 18, 2021
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 18, 2021
2721: Ensure faucet setup runs on BFT node without rollbacks r=rvl a=Anviking # Issue Number ADP-970, #2720, #2428 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Ensure faucet setup runs on BFT node, such that rollbacks can't mess it up # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> 2723: Use LineBuffering in unit tests r=rvl a=Anviking # Issue Number ADP-970 / #2472 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Try using line buffering in unit tests, like we do for integration tests # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed (retrying...): #duplicate |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 18, 2021
2723: Use LineBuffering in unit tests r=rvl a=Anviking # Issue Number ADP-970 / #2472 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Try using line buffering in unit tests, like we do for integration tests # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-970 / #2472
Overview
Comments