Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure faucet setup runs on BFT node without rollbacks #2721

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Ensure faucet setup runs on BFT node without rollbacks #2721

merged 1 commit into from
Jun 18, 2021

Conversation

Anviking
Copy link
Member

@Anviking Anviking commented Jun 16, 2021 •
edited
Loading

Issue Number

ADP-970, #2720, #2428

Overview

  • Ensure faucet setup runs on BFT node, such that rollbacks can't mess it up

Comments

@Anviking Anviking force-pushed the anviking/ADP-970/fix-cluster-setup branch from e1870a2 to 2c30675 Compare June 16, 2021 11:54
@Anviking Anviking self-assigned this Jun 16, 2021
@Anviking
Ensure cluster setup runs without rollbacks
b34687d 
This commit re-adds the setup specific callback from removed in 925b4d9
such that the fuacet setup is run on the BFT node, before pools are
registered and can roll back.

This should hopefully fix a #2720, #2428, and perhaps something more.
@Anviking Anviking force-pushed the anviking/ADP-970/fix-cluster-setup branch from 2c30675 to b34687d Compare June 16, 2021 12:57
@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Jun 16, 2021
@iohk-bors
Try #2721:
82ab9fb
@Anviking
Copy link
Member Author

Hydra failed with

     PATCH /wallets/0000000000000000000000000000000000000000/signatures/utxo_external/0H
     DELETE /wallets/0000000000000000000000000000000000000000/signatures/utxo_external/0H
     CONNECT /wallets/0000000000000000000000000000000000000000/signatures/utxo_external/0H
building of '/nix/store/mmrl1n9p85h3r0r3vqvjwyj4lhiys9h5-cardano-wallet-core-test-unit-2021.6.11-check' timed out after 900 seconds of silence

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 16, 2021 •
edited by Anviking
Loading

try

Build failed:

  adversaries can't affect usableKeys
    +++ OK, passed 100 tests.
  adversaries can't affect pointer ix
    +++ OK, passed 100 tests.
  (apply (cmds <> CmdSetPortfolioOf 0) s0) === s0
    +++ OK, passed 100 tests.
building of '/nix/store/hw8bp4cb653dkxnr103mklhwg4ya1qzf-cardano-wallet-core-test-unit-2021.6.11-check' timed out after 900 seconds of silence

😳 New location.

We just marked LoggingSpec, so maybe it times out after a certain time of running the tests, regardless of which tests it runs 🤔

@Anviking Anviking requested a review from rvl June 16, 2021 17:07
@rvl
Copy link
Contributor

rvl commented Jun 17, 2021

😳 New location.

I believe this means that you owe me 5 kr. 😝

@Anviking
Copy link
Member Author

bors try

iohk-bors bot added a commit that referenced this pull request Jun 17, 2021
@iohk-bors
Try #2721:
cf26e28
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 17, 2021 •
edited by Anviking
Loading

try

Build failed:

     OPTIONS /wallets/0000000000000000000000000000000000000000/keys/utxo_internal/0
     PUT /wallets/0000000000000000000000000000000000000000/keys/utxo_internal/0H
     POST /wallets/0000000000000000000000000000000000000000/keys/utxo_internal/0H
     PATCH /wallets/0000000000000000000000000000000000000000/keys/utxo_internal/0H
     DELETE /wallets/0000000000000000000000000000000000000000/keys/utxo_internal/0H
     CONNECT /wallets/0000000000000000000000000000000000000000/keys/utxo_internal/0H
     TRACE /wallets/0000000000000000000000000000000000000000/keys/utxo_internal/0H
     OPTIONS /wallets/0000000000000000000000000000000000000000/keys/utxo_internal/0H
     PUT /wallets/0000000000000000000000000000000000000000/keys/utxo_internal/1234
building of '/nix/store/zg3kizrzx8lsdj3w4znc8q0m1ig1affq-cardano-wallet-core-test-unit-2021.6.11-check' timed out after 900 seconds of silence

@Anviking
Copy link
Member Author

I believe this means that you owe me 5 kr.

Still worthwhile experiment, plus in that failure, we saw it pass the Sqlite properties and state machine tests.

rvl
rvl approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍
It's good we have Instafork now so that the BFT node is already in the target era at startup.

@rvl
Copy link
Contributor

rvl commented Jun 18, 2021

bors r+

iohk-bors bot added a commit that referenced this pull request Jun 18, 2021
@iohk-bors @Anviking @rvl
Merge #2721 #2723
7b6be98 
2721: Ensure faucet setup runs on BFT node without rollbacks r=rvl a=Anviking

# Issue Number

ADP-970, #2720, #2428


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Ensure faucet setup runs on BFT node, such that rollbacks can't mess it up


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


2723: Use LineBuffering in unit tests r=rvl a=Anviking

# Issue Number

ADP-970 / #2472 


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Try using line buffering in unit tests, like we do for integration tests


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 18, 2021 •
edited by Anviking
Loading

Build failed (retrying...):

   src/Test/Integration/Scenario/CLI/Shelley/Wallets.hs:754:18:
   1) CLI Specifications, SHELLEY_CLI_WALLETS, WALLETS_UTXO_02 - Utxo statistics works properly
        Waited longer than 90s to resolve action: "Wallet balance is as expected".
        expected: Quantity {getQuantity = 1562000000}
         but got: Quantity {getQuantity = 0}

   To rerun use: --match "/CLI Specifications/SHELLEY_CLI_WALLETS/WALLETS_UTXO_02 - Utxo statistics works properly/"

   src/Test/Integration/Scenario/CLI/Shelley/HWWallets.hs:129:18:
   2) CLI Specifications, SHELLEY_CLI_HW_WALLETS, HW_WALLETS_01x - Restoration from account public key preserves funds
        Waited longer than 90s to resolve action: "Wallet balance is as expected".

#2428 (it seems this PR isn't a fix then)

#WALLETS_UTXO_02

iohk-bors bot added a commit that referenced this pull request Jun 18, 2021
@iohk-bors @Anviking
Merge #2721
cd40e08 
2721: Ensure faucet setup runs on BFT node without rollbacks r=rvl a=Anviking

# Issue Number

ADP-970, #2720, #2428


# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Ensure faucet setup runs on BFT node, such that rollbacks can't mess it up


# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Johannes Lund <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 18, 2021

Build failed:

@Anviking
Copy link
Member Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 18, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit ca9cbed into master Jun 18, 2021
@iohk-bors iohk-bors bot deleted the anviking/ADP-970/fix-cluster-setup branch June 18, 2021 08:37
@Anviking Anviking mentioned this pull request Aug 26, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl approved these changes

Assignees

@Anviking Anviking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anviking @rvl