Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork Jormungandr #2313

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Fork Jormungandr #2313

merged 4 commits into from
Nov 17, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Nov 12, 2020

Jira issue

ADP-548

Overview

We are forking the cardano-wallet-jormungandr application into a new GitHub repo.

This repo will become cardano-node only.

cardano-wallet-jormungandr repo setup:

git fetch origin --prune --force --tags
git checkout master
git reset --hard v2020-11-03
git remote add jormungandr [email protected]:input-output-hk/cardano-wallet-jormungandr.git
git push jormungandr master --tags
git checkout -b cardano-wallet-jormungandr master
git branch --set-upstream-to=jormungandr/master --track

Comments

  • Remove cardano-wallet-jormungandr package from this repo.
  • Update the build scripts to remove jormungandr.
  • Copy github repository access settings across.

Future work

  • Update migration tests to use shelley backend ⇒ ADP-549.
  • Some jormungandr-specific code and tests in common modules could probably be removed - but it's not immediately obvious which. We will probably clean that up gradually.

@rvl rvl added the Improvement Mark a PR as an improvement, for auto-generated CHANGELOG label Nov 12, 2020
@rvl rvl self-assigned this Nov 12, 2020
iohk-bors bot added a commit that referenced this pull request Nov 12, 2020
2301: Reduce nix-shell eval memory usage r=jbgi a=rvl

### Issue Number

ADP-382 / #1888

### Overview

1. Similar memory and speed gains as in #2300. cardano-node was previously imported as a niv source. It is also part of the haskell.nix package set, because it's a stack.yaml dependency. So there were haskell package sets duplicated basically.

2. Add a `platform` argument to the `release.nix` jobset. This will split the jobset into three. With support from Hydra (input-output-hk/ci-ops#26), this will make evaluation use about 1/3 of the memory, and allow jobs to start building quicker.

### Comments

Removing cardano-wallet-jormungandr and nix build of jormungandr is done in #2313. This also reduces the weight to the nix-shell.



Co-authored-by: Rodney Lorrimar <[email protected]>
@rvl rvl force-pushed the rvl/fork-jormungandr branch 2 times, most recently from 6a1f9a9 to c1671c6 Compare November 17, 2020 01:29
@rvl rvl requested a review from jonathanknowles November 17, 2020 01:30
@rvl rvl force-pushed the rvl/fork-jormungandr branch from 54e1e3a to d146382 Compare November 17, 2020 02:52
Copy link
Contributor

@jonathanknowles jonathanknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Though I have one question about migration tests (see comments).

timeout_in_minutes: 60
agents:
system: x86_64-linux
# TODO: ADP-548 Port migrations test to shelley
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that we'll be without migration tests for a while?

If so, I think it would be worth making a ticket just for that (if there isn't one already), and upping the priority.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK the new ticket is ADP-549.

@rvl rvl force-pushed the rvl/fork-jormungandr branch from d146382 to fb2b1b8 Compare November 17, 2020 05:42
@rvl
Copy link
Contributor Author

rvl commented Nov 17, 2020

Thanks

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 17, 2020

Build succeeded:

@iohk-bors iohk-bors bot merged commit 1fe597e into master Nov 17, 2020
@iohk-bors iohk-bors bot deleted the rvl/fork-jormungandr branch November 17, 2020 06:17
iohk-bors bot added a commit that referenced this pull request Nov 30, 2020
2301: Reduce nix-shell eval memory usage r=rvl a=rvl

### Issue Number

ADP-382 / #1888

### Overview

1. Similar memory and speed gains as in #2300. cardano-node was previously imported as a niv source. It is also part of the haskell.nix package set, because it's a stack.yaml dependency. So there were haskell package sets duplicated basically.

2. Add a `platform` argument to the `release.nix` jobset. This will split the jobset into three. With support from Hydra (input-output-hk/ci-ops#26), this will make evaluation use about 1/3 of the memory, and allow jobs to start building quicker.

### Comments

- Removing cardano-wallet-jormungandr and nix build of jormungandr is done in #2313. This also reduces the weight to the nix-shell.
- It is best to merge this after #2245, because the iohk-monitoring build will be simpler.


Co-authored-by: Rodney Lorrimar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants