-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork Jormungandr #2313
Fork Jormungandr #2313
Conversation
2301: Reduce nix-shell eval memory usage r=jbgi a=rvl ### Issue Number ADP-382 / #1888 ### Overview 1. Similar memory and speed gains as in #2300. cardano-node was previously imported as a niv source. It is also part of the haskell.nix package set, because it's a stack.yaml dependency. So there were haskell package sets duplicated basically. 2. Add a `platform` argument to the `release.nix` jobset. This will split the jobset into three. With support from Hydra (input-output-hk/ci-ops#26), this will make evaluation use about 1/3 of the memory, and allow jobs to start building quicker. ### Comments Removing cardano-wallet-jormungandr and nix build of jormungandr is done in #2313. This also reduces the weight to the nix-shell. Co-authored-by: Rodney Lorrimar <[email protected]>
6a1f9a9
to
c1671c6
Compare
54e1e3a
to
d146382
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Though I have one question about migration tests (see comments).
.buildkite/nightly.yml
Outdated
timeout_in_minutes: 60 | ||
agents: | ||
system: x86_64-linux | ||
# TODO: ADP-548 Port migrations test to shelley |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that we'll be without migration tests for a while?
If so, I think it would be worth making a ticket just for that (if there isn't one already), and upping the priority.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK the new ticket is ADP-549.
Until it can be moved from jormungandr to shelley.
d146382
to
fb2b1b8
Compare
Thanks bors r+ |
Build succeeded: |
2301: Reduce nix-shell eval memory usage r=rvl a=rvl ### Issue Number ADP-382 / #1888 ### Overview 1. Similar memory and speed gains as in #2300. cardano-node was previously imported as a niv source. It is also part of the haskell.nix package set, because it's a stack.yaml dependency. So there were haskell package sets duplicated basically. 2. Add a `platform` argument to the `release.nix` jobset. This will split the jobset into three. With support from Hydra (input-output-hk/ci-ops#26), this will make evaluation use about 1/3 of the memory, and allow jobs to start building quicker. ### Comments - Removing cardano-wallet-jormungandr and nix build of jormungandr is done in #2313. This also reduces the weight to the nix-shell. - It is best to merge this after #2245, because the iohk-monitoring build will be simpler. Co-authored-by: Rodney Lorrimar <[email protected]>
Jira issue
ADP-548
Overview
We are forking the cardano-wallet-jormungandr application into a new GitHub repo.
This repo will become cardano-node only.
cardano-wallet-jormungandr repo setup:
Comments
Future work