Make nix-shell evaluation faster #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
RESOLVING ISSUE
hamishmack
reviewed
Nov 6, 2020
shell.nix
Outdated
| cabal = { | ||
| version = "3.2.0.0"; | ||
| plan-sha256 = "0ik4ws852dk7wchbhc84w5ac149myvc1az7rxapfy0hdmiiwjh2j | ||
| "; |
|
I am not sure if we still need |
hamishmack
approved these changes
Nov 6, 2020
|
@hamishmack I tried removing the So perhaps they do help with caching the cabal plan. |
rvl
force-pushed
the
rvl/adp-382/nix-faster
branch
from
bd22df4 to
cc6fd10
Compare
|
Is that derivation actually running |
|
I see, yes you are right, it was just copying files. |
ghcid -> fsnotify -> hfsevents
|
bors r+ |
|
Build succeeded: |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 12, 2020
2301: Reduce nix-shell eval memory usage r=jbgi a=rvl ### Issue Number ADP-382 / #1888 ### Overview 1. Similar memory and speed gains as in #2300. cardano-node was previously imported as a niv source. It is also part of the haskell.nix package set, because it's a stack.yaml dependency. So there were haskell package sets duplicated basically. 2. Add a `platform` argument to the `release.nix` jobset. This will split the jobset into three. With support from Hydra (input-output-hk/ci-ops#26), this will make evaluation use about 1/3 of the memory, and allow jobs to start building quicker. ### Comments Removing cardano-wallet-jormungandr and nix build of jormungandr is done in #2313. This also reduces the weight to the nix-shell. Co-authored-by: Rodney Lorrimar <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Nov 30, 2020
2301: Reduce nix-shell eval memory usage r=rvl a=rvl ### Issue Number ADP-382 / #1888 ### Overview 1. Similar memory and speed gains as in #2300. cardano-node was previously imported as a niv source. It is also part of the haskell.nix package set, because it's a stack.yaml dependency. So there were haskell package sets duplicated basically. 2. Add a `platform` argument to the `release.nix` jobset. This will split the jobset into three. With support from Hydra (input-output-hk/ci-ops#26), this will make evaluation use about 1/3 of the memory, and allow jobs to start building quicker. ### Comments - Removing cardano-wallet-jormungandr and nix build of jormungandr is done in #2313. This also reduces the weight to the nix-shell. - It is best to merge this after #2245, because the iohk-monitoring build will be simpler. Co-authored-by: Rodney Lorrimar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-382 / #1888
Overview
Comments