Enable STAKE_POOLS_LIST tests to run in isolation.
#1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it possible to run tests from `STAKE_POOLS_LIST_01` in isolation, without having to run the entire stake pool integration test suite.
jonathanknowles
changed the title
STAKE_POOLS_LIST tests to run in isolation.STAKE_POOLS_LIST tests to run in isolation.
Anviking
approved these changes
Jul 13, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 13, 2020
1899: Enable `STAKE_POOLS_LIST` tests to run in isolation. r=jonathanknowles a=jonathanknowles # Issue Number #1819 # Overview The very first test in the `STAKE_POOLS_LIST_01` series has implicit dependency on time. If run _too soon_ (as is the case if the test is run in isolation), such that the wallet has not yet had a chance to catch up with tip, then the wallet API will return an empty list, which will cause a test failure. To fix this, this PR nests the test inside an `eventually` combinator, which allows the test to be run in isolation (just like the others in the `STAKE_POOLS_LIST_01` series). Additional changes: - [x] Fixes some spelling errors. - [x] Reformatting to comply with our coding standards. Co-authored-by: Jonathan Knowles <[email protected]>
jonathanknowles
added
the
IMPROVEMENT
Build failed |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 13, 2020
1845: Add latency benchmark for shelley r=rvl a=rvl Relates to #1825. ### Overview - Ports latency benchmarks to shelley backend. - Refactors duplicate code into a shared module. - Adds listStakePools to benchmarks 1899: Enable `STAKE_POOLS_LIST` tests to run in isolation. r=jonathanknowles a=jonathanknowles # Issue Number #1819 # Overview The very first test in the `STAKE_POOLS_LIST_01` series has implicit dependency on time. If run _too soon_ (as is the case if the test is run in isolation), such that the wallet has not yet had a chance to catch up with tip, then the wallet API will return an empty list, which will cause a test failure. To fix this, this PR nests the test inside an `eventually` combinator, which allows the test to be run in isolation (just like the others in the `STAKE_POOLS_LIST_01` series). Additional changes: - [x] Fixes some spelling errors. - [x] Reformatting to comply with our coding standards. Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]>
Build failed (retrying...) |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1819
Overview
The very first test in the
STAKE_POOLS_LIST_01series has implicit dependency on time. If run too soon (as is the case if the test is run in isolation), such that the wallet has not yet had a chance to catch up with tip, then the wallet API will return an empty list, which will cause a test failure.To fix this, this PR nests the test inside an
eventuallycombinator, which allows the test to be run in isolation (just like the others in theSTAKE_POOLS_LIST_01series).Additional changes: