-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latency benchmark for shelley #1845
Conversation
f347c0e
to
50fdd86
Compare
f0f8e6a
to
414ba03
Compare
50fdd86
to
c39123c
Compare
dc31f7b
to
d185ab5
Compare
Probably not related to this pr (?), but I got this when running shelley latency benchmark locally:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! why not to introduce the same naming here https://github.com/input-output-hk/cardano-wallet/blob/master/lib/byron/bench/Latency.hs#L150 and https://github.com/input-output-hk/cardano-wallet/blob/master/lib/jormungandr/test/bench/Latency.hs#L145 Your naming is better of course:-)
Yes thanks @paweljakubas I should do that. (edit: it's done) |
3e2f951
to
87fa6b3
Compare
bors r+ |
1845: Add latency benchmark for shelley r=rvl a=rvl Relates to #1825. ### Overview - Ports latency benchmarks to shelley backend. - Refactors duplicate code into a shared module. - Adds listStakePools to benchmarks Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]>
Build failed |
87fa6b3
to
dd15e8e
Compare
bors r+ |
1845: Add latency benchmark for shelley r=rvl a=rvl Relates to #1825. ### Overview - Ports latency benchmarks to shelley backend. - Refactors duplicate code into a shared module. - Adds listStakePools to benchmarks 1899: Enable `STAKE_POOLS_LIST` tests to run in isolation. r=jonathanknowles a=jonathanknowles # Issue Number #1819 # Overview The very first test in the `STAKE_POOLS_LIST_01` series has implicit dependency on time. If run _too soon_ (as is the case if the test is run in isolation), such that the wallet has not yet had a chance to catch up with tip, then the wallet API will return an empty list, which will cause a test failure. To fix this, this PR nests the test inside an `eventually` combinator, which allows the test to be run in isolation (just like the others in the `STAKE_POOLS_LIST_01` series). Additional changes: - [x] Fixes some spelling errors. - [x] Reformatting to comply with our coding standards. Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]>
Build failed (retrying...) |
1845: Add latency benchmark for shelley r=rvl a=rvl Relates to #1825. ### Overview - Ports latency benchmarks to shelley backend. - Refactors duplicate code into a shared module. - Adds listStakePools to benchmarks Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]>
Build failed |
bors r+ |
1845: Add latency benchmark for shelley r=rvl a=rvl Relates to #1825. ### Overview - Ports latency benchmarks to shelley backend. - Refactors duplicate code into a shared module. - Adds listStakePools to benchmarks Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]>
Build failed |
bors r+ |
Build succeeded |
Relates to #1825.
Overview