Clarify the description of getNetworkParameters in the API and CLI.
#1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that this command shows parameters for the current epoch.
Make it clear that this endpoint returns parameters for the current epoch.
8 tasks
rvl
approved these changes
May 28, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
May 28, 2020
1698: Clarify the description of `getNetworkParameters` in the API and CLI. r=jonathanknowles a=jonathanknowles # Related Issues #1690 # Overview This PR clarifies the descriptions of the `getNetworkParameters` API endpoint and the associated `network parameters` CLI command, in response to [review feedback](https://github.com/input-output-hk/cardano-wallet/pull/1694/files#r431011565) for #1694, Co-authored-by: Jonathan Knowles <[email protected]>
|
bors r- |
Canceled |
rvl
approved these changes
May 28, 2020
There was a problem hiding this comment.
Actually ... technically those parameters which are returned are from genesis block because none of them are updatable. They will never change.
And also technically, suppose that there are updatable parameters in there. They will be for latest epoch which the node has synced, which is not necessarily the current epoch. Although I think it's an acceptable simplification to say "current epoch" in this context.
|
bors r+ |
Build succeeded |
iohk-bors
bot
deleted the
jonathanknowles/getNetworkParameters-api-cli-descriptions
branch
KtorZ
added
the
ADDING FEATURE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#1690
Overview
This PR clarifies the descriptions of the
getNetworkParametersAPI endpoint and the associatednetwork parametersCLI command, in response to review feedback for #1694,