Remove epochId argument from getNetworkParameters.
#1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can revert this change if we ever need to reinstate the type.
We can revert this change if we ever need to reinstate the type.
We no longer need to test the `epochId` path parameter for the `getNetworkParameters` API function.
jonathanknowles
force-pushed
the
jonathanknowles/remove-epochId-from-getNetworkParameters
branch
from
5b9c039 to
873f0eb
Compare
We no longer need to test the `epoch` parameter for the `network parameters` function.
We no longer need the `epochId` path parameter for the `getNetworkParameters` function.
jonathanknowles
force-pushed
the
jonathanknowles/remove-epochId-from-getNetworkParameters
branch
from
56a49af to
c127bea
Compare
jonathanknowles
changed the title
epochId argument from getNetworkParameters.epochId argument from getNetworkParameters.
We no longer expect to see the `EPOCH_NUMBER` parameter in the CLI help for `network parameters`.
jonathanknowles
added this to the (ADP-244) Cardano decentralization progress milestone
jonathanknowles
deleted the
jonathanknowles/remove-epochId-from-getNetworkParameters
branch
iohk-bors bot
added a commit
that referenced
this pull request
May 28, 2020
1698: Clarify the description of `getNetworkParameters` in the API and CLI. r=jonathanknowles a=jonathanknowles # Related Issues #1690 # Overview This PR clarifies the descriptions of the `getNetworkParameters` API endpoint and the associated `network parameters` CLI command, in response to [review feedback](https://github.com/input-output-hk/cardano-wallet/pull/1694/files#r431011565) for #1694, Co-authored-by: Jonathan Knowles <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
May 28, 2020
1698: Clarify the description of `getNetworkParameters` in the API and CLI. r=jonathanknowles a=jonathanknowles # Related Issues #1690 # Overview This PR clarifies the descriptions of the `getNetworkParameters` API endpoint and the associated `network parameters` CLI command, in response to [review feedback](https://github.com/input-output-hk/cardano-wallet/pull/1694/files#r431011565) for #1694, Co-authored-by: Jonathan Knowles <[email protected]>
jonathanknowles
added
the
IMPROVEMENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1690
Overview
This PR:
epochIdargument from thegetNetworkParametersAPI function.epochargument from thenetwork parametersCLI command.ApiEpochNumbertype. (We can reinstate it later, if necessary.)ErrNoSuchEpochtype. (We can reinstate it later, if necessary.)Comments
cardano-wallet, and help them transition to the modified endpoint. (See https://input-output-rnd.slack.com/archives/C7PJ29FME/p1590569319044000)