Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify theme context for monogram #298

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Specify theme context for monogram #298

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ab3328
Specify theme context for monogram
Nov 22, 2022
c9c5470
Apply suggestion from review
Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
<img
src='https://carbonplan-assets.s3.amazonaws.com/monogram/dark-small.png'
height='48'
/>
<p align="left" >
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://carbonplan-assets.s3.amazonaws.com/monogram/light-small.png">
<source media="(prefers-color-scheme: light)" srcset="https://carbonplan-assets.s3.amazonaws.com/monogram/dark-small.png">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it looks like we'll get the same behavior if this is removed because we'll just fallback to the default in lightmode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I'll take that line out. Do you think it would be worth using this feature for the other repos as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think so! maybe tracking across repos is a good candidate for the project board?

<img alt="CarbonPlan monogram." height="48" src="https://carbonplan-assets.s3.amazonaws.com/monogram/dark-small.png">
</picture>
</p>

**climate downnscaling using cmip6 data**

Expand Down