Specify theme context for monogram #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
katamartin
approved these changes
Nov 22, 2022
README.md
Outdated
| <p align="left" > | ||
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset="https://carbonplan-assets.s3.amazonaws.com/monogram/light-small.png"> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://carbonplan-assets.s3.amazonaws.com/monogram/dark-small.png"> |
There was a problem hiding this comment.
nit: it looks like we'll get the same behavior if this is removed because we'll just fallback to the default in lightmode
There was a problem hiding this comment.
good point, I'll take that line out. Do you think it would be worth using this feature for the other repos as well?
There was a problem hiding this comment.
yeah I think so! maybe tracking across repos is a good candidate for the project board?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.