fix(sketch): support glyph-only assets #8787
Conversation
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 602cdba 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/610e27dd89d3c60007c4d5c0 😎 Browse the preview: https://deploy-preview-8787--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 602cdba 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/610e27ddfcbfd0000749b089 😎 Browse the preview: https://deploy-preview-8787--carbon-components-react.netlify.app |
emyarod
force-pushed
the
8786-sketch-icons-sync-handle-glyph-assets
branch
from
a4f1506
to
4a84389
Compare
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 602cdba 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/610e27ddec09e70008eb3d37 😎 Browse the preview: https://deploy-preview-8787--carbon-react-next.netlify.app |
joshblack
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Closes #8786
related #8546
This PR fixes a Sketch plugin icons sync regression caused by the glyph-only assets introduced in #8546. The fix follows along the lines of #8724 by defaulting to the first available asset if no 32x32 asset is found since #8546 introduces assets with no 32px size
Testing / Reviewing
Confirm the icons sync commands function as expected and that there are no regressions with the remaining commands
carbon-elements.sketchplugin.zip