fix(icon-build-helpers): support glyph-only assets #8724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy Preview for carbon-elements ready! Built with commit 782062e |
|
Deploy Preview for carbon-components-react ready! Built without sensitive environment variables with commit 782062e https://deploy-preview-8724--carbon-components-react.netlify.app |
|
It seems like in the originating PR, they were against adding sizes and wanted them to remain |
emyarod
force-pushed
the
icon-builder-support-glyph-only-assets
branch
2 times, most recently
from
7b951d1
to
3aef975
Compare
emyarod
force-pushed
the
icon-builder-support-glyph-only-assets
branch
from
3aef975
to
4d7f546
Compare
joshblack
approved these changes
May 21, 2021
tw15egan
approved these changes
May 24, 2021
This was referenced May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #8546
This PR defaults to glyph assets in the icon builders when no default asset size is defined
copying my comment from the PR thread