-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MultiSelect.Filterable): onMenuChange is not being called #8752
fix(MultiSelect.Filterable): onMenuChange is not being called #8752
Conversation
DCO Assistant Lite bot All contributors have signed the DCO. |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 6f1b4b2 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60ad65d7e77d550007341595 😎 Browse the preview: https://deploy-preview-8752--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 6f1b4b2 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60ad65d79df0370008ab240a 😎 Browse the preview: https://deploy-preview-8752--carbon-components-react.netlify.app/iframe |
I have read the DCO document and I hereby sign the DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing a fix! 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
…n-design-system#8752) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Closes #8749
Currently the function was relying on the inputBlur switch case to call the handleOnMenuChange, but that was not enough and most of the times when clicking outside the dropdown the onMenuChange prop was not being called.
Fixing the issue by Calling handleOnMenuChange function inside the handleOnOuterClick.
Changelog
Changed
Removed