fix(NumberInput): set negative tabindex on number controls #8090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit a1dff40 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit a1dff40 https://deploy-preview-8090--carbon-components-react.netlify.app |
This was referenced Mar 15, 2021
dakahn
approved these changes
Mar 16, 2021
jnm2377
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4185
This PR sets a negative tabindex on the increment/decrement controls on the number input so that it is not tabbable to match the vanilla number input and w3 examples. The component currently reads correctly in VO and this change should have no effect on the VO behavior
Testing / Reviewing
Confirm the number input controls are not tabbable and that VO still correctly reads number input interactions