Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVT 3 NumberInput Components - VO does not announce value or increment when the up and down arrows used to input the number #4185

Closed
snidersd opened this issue Oct 2, 2019 · 6 comments · Fixed by #8090
Assignees
Labels

Comments

@snidersd
Copy link

snidersd commented Oct 2, 2019

Environment

macOS Mojave version 10.14.2
Chrome version 72.0.3626.96 (Official Build) (64-bit)

Detailed Description

With VoiceOver enabled Tab to number input. (Focus is on the up arrow)
Press the up arrow. Voice over does not announce the value or the increment number.
Tab to the down arrow is the same.
Tab to the Number input and the value is announced.
Enter an odd number directly into the Number field.
Shift-Control-Option to enter the stepper
Control Option Up or Down Arrow keys to change the number.
The number is not announced correctly by VoiceOver.

Expected result:

When on an arrow that increments the number up or down the user should be advised that the number is incrementing by 10 as well as the number that is displayed in the number input field.
If a user inputs a number directly that is in the wrong increments they should get a warning.
If they change the number using the VO Control-Option-Up or Down arrow keys the number should be announced correctly.

@snidersd snidersd added this to the Number Input - A11y Project Team milestone Oct 2, 2019
@abbeyhrt abbeyhrt self-assigned this Oct 14, 2019
@dakahn dakahn added the severity: 1 https://ibm.biz/carbon-severity label Oct 15, 2019
@abbeyhrt
Copy link
Contributor

@snidersd if you get the chance, could you try out VO in Safari for the NumberInput? I'm finding that aria-atomic, which should help the value announce correctly when using arrow keys, just isn't working in Chrome but it is in Safari and Firefox.

@snidersd
Copy link
Author

@abbeyhrt - I just tested this with macOS on Safari 13.0.2 and Win10 on FF 68.2.0. The only issue found is that the arrows that increment the number up and down are in the Tab order, but the number is not announced when it changes using the keyboard. I also tested it on macOS with FF 68 (ESR) and Chrome 78.0.3904.70 and both fail.

@dakahn dakahn modified the milestones: Number Input - A11y Project Team, Carbon WCAG Compliance Nov 21, 2019
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
@abbeyhrt abbeyhrt removed their assignment Jan 16, 2020
@dakahn
Copy link
Contributor

dakahn commented Jan 17, 2020

bug filed in Chromium bug tracker here

@dakahn
Copy link
Contributor

dakahn commented Mar 5, 2020

Looks like the Chromium team was unable to reproduce the error. Unblocking and moving to backlog.
https://bugs.chromium.org/p/chromium/issues/detail?id=1043216#c4

@emyarod
Copy link
Member

emyarod commented Mar 12, 2021

since the native HTML number input and w3's spin buttons don't allow keyboard navigation to the increment and decrement buttons, would it be better to just use arrow keys while the number input field is focused rather than tabbing to the increment/decrement buttons? I think we could get VO to announce changes caused by the increment/decrement buttons with aria-live but that may result in redundant readings

@emyarod
Copy link
Member

emyarod commented Mar 12, 2021

as it stands now though, arrow keys while the input field is focused will cause VO to correctly announce the value

image

arrow key stepping seems to read correctly in VO

on a side note #8090 will remove the nonnegative tabindex on the input controls so that it matches the native number input and the w3 examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants