-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataTable): fix padding issue when only some headers are sortable #7888
fix(DataTable): fix padding issue when only some headers are sortable #7888
Conversation
Deploy preview for carbon-elements ready! Built with commit ea411a5 |
Deploy preview for carbon-components-react ready! Built with commit ea411a5 https://deploy-preview-7888--carbon-components-react.netlify.app |
Deploy preview for carbon-elements ready! Built with commit d6138f1 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit d6138f1 https://deploy-preview-7888--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to make sure I have the context, this reverts/updates #7726 is that right?
c4de80f
to
eb2f05c
Compare
eb2f05c
to
c4c3a77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Ref #7791
Ref #7726 (comment)
Changelog
Added
isSortable
is set onDataTable
but some specific Headers are not sortableChanged
core
tosort
scss fileTesting / Reviewing
You can test this by changing the header map inside
TableHead --> TableRow
in theDataTable-sorting.story
to the code below. Also, try removingisSortable
fromDataTable
to test different variations.