fix(sketch): resolve sketch plugin color layer style duplication #7762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 tasks
|
Deploy preview for carbon-elements ready! Built with commit e774911 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit e774911 https://deploy-preview-7762--carbon-components-react.netlify.app |
joshblack
approved these changes
Feb 8, 2021
laurenmrice
requested changes
Feb 9, 2021
emyarod
force-pushed
the
7734-resolve-sketch-plugin-color-layer-style-duplication
branch
2 times, most recently
from
381d201
to
7d3da2d
Compare
|
here is the updated plugin which should rename layers in place. the layers should now have the correct name format and no duplicate layers will be generated |
emyarod
force-pushed
the
7734-resolve-sketch-plugin-color-layer-style-duplication
branch
from
7d3da2d
to
891bf9a
Compare
emyarod
force-pushed
the
7734-resolve-sketch-plugin-color-layer-style-duplication
branch
from
891bf9a
to
c369682
Compare
laurenmrice
approved these changes
Feb 11, 2021
emyarod
deleted the
7734-resolve-sketch-plugin-color-layer-style-duplication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7734
related #5664 #5692 #5744
This PR resolves the color layer style duplication issue. Since we have changed direction in how we expect shared styles to be named, we can undo some changes initially introduced in #5744 to address #5692. We also add some logic to check for the breaking change in #5664 and rename the style layers in place
Changelog
Changed
formatSharedStyleNameto be more descriptiveRemoved
Testing / Reviewing
color style names should no longer contain style type, and any references to color style type should no longer be in the plugin codebase
carbon-elements.sketchplugin.zip