Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shared styles for icon stroke #5692

Closed
joshblack opened this issue Mar 24, 2020 · 3 comments · Fixed by #5744
Closed

Create shared styles for icon stroke #5692

joshblack opened this issue Mar 24, 2020 · 3 comments · Fixed by #5744

Comments

@joshblack
Copy link
Contributor

We need to author shared styles similar to how we do now for IDL and our tokens but specifically targeting icon stroke. This issue is for creating the command and code necessary for generating these shared styles.

The naming convention for this feature is: color / border / <color> / <grade>

We have a couple of options when it comes to commands, but we could add it to existing color sync commands or do a standalone command. Either works!

@laurenmrice
Copy link
Member

laurenmrice commented Mar 25, 2020

here is a sketch file with an example of how the color styles should be:
https://ibm.box.com/s/uz7nrdlt1o9szlzb6rz96kti1q8u4fnp


Trying to decide which naming convention makes more sense from a code and sketch perspective. border or stroke. From a sketch perspective, border makes more sense, is this the terminology you are using in code?

@emyarod
Copy link
Member

emyarod commented Mar 25, 2020

in code it's a stroke but I named it border in my draft PR and will probably keep that since that's what it's called in Sketch

@laurenmrice
Copy link
Member

ok cool lets go with border

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants