fix(button): avoid overriding styles on SVGS with paths #7632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit b0a8bf9 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit b0a8bf9 https://deploy-preview-7632--carbon-components-react.netlify.app |
aledavila
approved these changes
Jan 22, 2021
joshblack
approved these changes
Jan 22, 2021
laurenmrice
approved these changes
Jan 25, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7631
This PR resolves an SVG fill color issue with danger and ghost icon buttons where the icons would not render properly (refer to referenced tickets)
Changelog
Changed
Testing / Reviewing
Confirm the button variants appear correct