Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghost and danger icon button SVGs rendering incorrectly #7631

Closed
emyarod opened this issue Jan 22, 2021 · 0 comments · Fixed by #7632
Closed

Ghost and danger icon button SVGs rendering incorrectly #7631

emyarod opened this issue Jan 22, 2021 · 0 comments · Fixed by #7632
Assignees
@emyarod
Labels
component: button role: dev 🤖 type: bug 🐛

Comments

@emyarod
Copy link
Member

emyarod commented Jan 22, 2021

Detailed description

related #5312 #5313 #5720 #5722

Describe in detail the issue you're having.

originally reported in #7618 comments by @tw15egan

Not introduced in this PR, but I noticed the Danger variant with icons are rendering wrong

Screen Shot 2021-01-21 at 2 44 57 PM Screen Shot 2021-01-21 at 2 44 44 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
component: button role: dev 🤖 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(button): avoid overriding styles on SVGS with paths emyarod/carbon
1 participant
@emyarod