fix(tag): add title to tags

[tw15egan]

Closes #6111

The title attribute on Tag allows the user to customize to text that appears on the aria-label for the close icon. This PR adds a boolean prop, enableTagTitle, that when enabled takes the value of the tag and will display it on hover.

Changelog

New

• enableTagTitle prop to allow for a title attribute to be added on the Tag

Changed

• title now is added to the close icon, if provided. Previously was only being added as an aria-label, which due to the naming seems confusing.
• Text updates to the Tag story

Testing / Reviewing

Enable/disable the new prop, ensure it works properly

[netlify]

Deploy preview for carbon-elements ready!

Built with commit daf9563

https://deploy-preview-6112--carbon-elements.netlify.app

[netlify]

Deploy preview for carbon-components-react ready!

Built with commit daf9563

https://deploy-preview-6112--carbon-components-react.netlify.app

[joshblack]

@tw15egan would we want to set the title by default, or nah?

[tw15egan]

@joshblack doesn't make much of a difference to me, figured it would be best to opt into this feature than to make it default

[emyarod]

I'm not sure if there are additional a11y reasons for only setting the title to filter tags (#4163, #4863) but if we do want to apply it to non filter tags (and it doesn't have any a11y impact), I think it would be better to keep the API surface area low and set it by default. it seems there is a workaround already according to the original issue author so just want to double check why title is specific to filter tags at the moment. my guess is because we don't encourage truncating tags by default?

[asudoh]

LGTM basically, assuming that we have a condition where doesn't want the title hover. Thanks @tw15egan!

[tw15egan]

@emyarod updated it to be enabled by default 👍

@asudoh added your changes 👍

[emyarod]

does there need to be a prop for enabling the title? it should just automatically take the prop value right?

[tw15egan]

@emyarod do we want it always to be enabled with no way to remove it? I was just following convention like what we do with MultiSelect and useTitleInItem

[emyarod]

for multiselect I believe that prop is originally from a few years ago and more recently we have been setting titles unconditionally (https://github.com/carbon-design-system/carbon/pull/5621/files #5102). but I think the context for those components is slightly different from tags

what I meant in my earlier comment (#6112 (comment)) was I think it makes more sense for the title logic to be identical (or similar) regardless of whether or not it is a filter tag. but if it makes sense to conditionally set the title only for non-filter tags then the new prop is fine

[tw15egan]

I'm good with that, I'll just set it by default and remove the prop

[asudoh]

LGTM 👍, wanted to have @emyarod's final review. Thanks @tw15egan for the update!

[emyarod]

looks good to me

[asudoh]

🎉