Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(listbox): set default title attributes to item text #5102

Merged
merged 9 commits into from
Jan 20, 2020
Merged

fix(listbox): set default title attributes to item text #5102

merged 9 commits into from
Jan 20, 2020

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jan 20, 2020

Closes #4495
Closes #4507

This PR sets the default title attribute for listbox menu items to be the item text so the full text can be viewed even if it is truncated in the menu. Users that have custom itemToString functions will need to implement this themselves though. The dropdown story has been updated to include an example

Testing / Reviewing

Ensure the full listbox menu item text is visible on all listbox components (combobox/dropdown/multiselect/filterable multiselect)

@emyarod emyarod requested a review from a team as a code owner January 20, 2020 18:29
@ghost ghost requested review from dakahn and joshblack January 20, 2020 18:29
@emyarod emyarod force-pushed the 4495-listbox-title-attribute branch from 647531b to 5b1176f Compare January 20, 2020 18:30
@netlify
Copy link

netlify bot commented Jan 20, 2020

Deploy preview for the-carbon-components ready!

Built with commit 647531b

https://deploy-preview-5102--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 20, 2020

Deploy preview for carbon-components-react ready!

Built with commit 647531b

https://deploy-preview-5102--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 20, 2020

Deploy preview for carbon-elements failed.

Built with commit 647531b

https://app.netlify.com/sites/carbon-elements/deploys/5e25f172832e8d0008b408a1

@netlify
Copy link

netlify bot commented Jan 20, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 0108486

https://deploy-preview-5102--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Jan 20, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 0108486

https://deploy-preview-5102--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 20, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 0108486

https://deploy-preview-5102--the-carbon-components.netlify.com

tw15egan
tw15egan approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, able to see the title on truncated text 👍 ✅

@asudoh asudoh merged commit 6202406 into carbon-design-system:master Jan 20, 2020
@emyarod emyarod deleted the 4495-listbox-title-attribute branch January 21, 2020 16:05
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@bjornalm bjornalm mentioned this pull request Feb 14, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
@emyarod emyarod mentioned this pull request May 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@tw15egan tw15egan tw15egan approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
5 participants
@emyarod @joshblack @tw15egan @dakahn @asudoh