fix(date-picker): use inset outline for focused selected day #6095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for carbon-elements ready! Built with commit 0b480a3 |
|
Deploy preview for carbon-components-react ready! Built with commit 0b480a3 https://deploy-preview-6095--carbon-components-react.netlify.app |
joshblack
approved these changes
May 15, 2020
dakahn
approved these changes
May 15, 2020
emyarod
force-pushed
the
5308-focused-date-picker-day-button-outline
branch
2 times, most recently
from
dbe287a
to
20640a5
Compare
emyarod
force-pushed
the
5308-focused-date-picker-day-button-outline
branch
from
20640a5
to
0b480a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5308
This PR adds an inset focus outline to the selected day in the date picker calendar
Testing / Reviewing
Confirm the selected, focused day in the date picker with calendar appears correct