Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date-picker] focus state on calendar dropdown clashes with selected date #5308

Closed
dakahn opened this issue Feb 10, 2020 · 1 comment · Fixed by #6095
Closed

[date-picker] focus state on calendar dropdown clashes with selected date #5308

dakahn opened this issue Feb 10, 2020 · 1 comment · Fixed by #6095

Comments

@dakahn
Copy link
Contributor

dakahn commented Feb 10, 2020

Give the date picker component keyboard focus and hit the down arrow to open the calendar dropdown. Focus has moved to the dropdown component, but if there is a previously selected date visually the focus state is undetectable
The selected date and the currently focused date is 2/5
The selected date and the currently focused date is 2/5

@snidersd tagging you here since you found this one

@aagonzales
Copy link
Member

Good catch, for selected+focus lets treat it the same we do with our primary button, so it should get that 1px white inset border.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants