Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fileUploader): add in disabled styles #3799

Merged
merged 2 commits into from
Aug 22, 2019
Merged

fix(fileUploader): add in disabled styles #3799

merged 2 commits into from
Aug 22, 2019

Conversation

tw15egan
Copy link
Member

Closes #3791

Adds in disabled styles for disabled FileUploader

Changelog

New

  • Adds disabled class if the disabled prop is passed down
  • aria-disabled on the label
  • The button can not be tabbed to when disabled

Changed

  • Made sure outline color also gets disabled colors for non-buttons using button classes

Testing / Reviewing

  1. Disable the button
  2. The button can not be clicked/receive focus styles when disabled
  3. The button can not be tabbed to when disabled

@tw15egan tw15egan requested a review from a team August 22, 2019 18:40
@ghost ghost requested review from abbeyhrt and vpicone and removed request for a team August 22, 2019 18:40
@netlify
Copy link

netlify bot commented Aug 22, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 43003f4

https://deploy-preview-3799--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 22, 2019 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 43003f4

https://deploy-preview-3799--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Aug 22, 2019 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit 43003f4

https://app.netlify.com/sites/carbon-components-react/deploys/5d5f1e9094b7cc00083d35d7

asudoh
asudoh approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

@asudoh asudoh merged commit 9bc9b24 into carbon-design-system:master Aug 22, 2019
@jnm2377 jnm2377 mentioned this pull request Sep 4, 2019
Closed
17 tasks
@tw15egan tw15egan deleted the fileuploader-disabled branch April 28, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@joshblack joshblack joshblack approved these changes

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt

@vpicone vpicone Awaiting requested review from vpicone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileUploader component in React: disabled property doesn't work
3 participants
@tw15egan @asudoh @joshblack