Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new pictograms from backlog 02 #11942

Merged

Conversation

dudley-ibm
Copy link
Contributor

Closes #

{{closes issues 134, 144, 156, 157 & 159}}

Changelog

New

  • {{New additions and their categories:
    Issue Inline SVG icons: remove svgxuse and carbon-icons #134
    accelerating-transformation (Cloud)
    agility-with-hybrid-multicloud (Cloud)
    confidential-computing (Cloud)
    controls-framework (Cloud)
    faster-innovation-with-partners (Cloud)
    keep-your-own-key (Cloud)
    lowering-risk (Cloud)
    new-financial-customer-experiences (Cloud)
    new-revenue-streams (Cloud)
    redefining-financial-services (Cloud)
    reducing-cost (Cloud)
    streamline--operations (Cloud)

Issue #144
inner-source (Design and development)

Issue #156
budapest--lab-skyline (Cities)

Issue #157
budapest--citadella (Cities)

Issue #159
cloud--platform (Cloud)}}

Changed

  • {{Changed category name from "Design and Development" to "Design and development" with a lower-case d in development}}

Testing / Reviewing

{{ These pictograms should show up on both the carbon and IBM Design Language sitest }}

@netlify
Copy link

netlify bot commented Aug 11, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2872536
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62fd020edb068f000882eed3
😎 Deploy Preview https://deploy-preview-11942--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 11, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 2872536
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62fd020e0cc6ce0009249a02
😎 Deploy Preview https://deploy-preview-11942--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dudley-ibm dudley-ibm requested a review from a team as a code owner August 11, 2022 17:58
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@dakahn
Copy link
Contributor

dakahn commented Aug 17, 2022

@dudley-ibm Nice! Glad to see updating those tests worked out fine

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 17, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the status: ready to merge 🎉 label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants