Skip to content

fix(slider): add labelledby to slider div #11798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2022
Merged

fix(slider): add labelledby to slider div #11798

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9bfe7d
fix(slider): add labelledby to slider div
aledavila Jul 13, 2022
a116706
chore(slider): update aria-labelledby
aledavila Jul 14, 2022
89a67dc
Merge branch 'v10' into aledavila-patch-1
aledavila Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react/src/components/Slider/Slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,7 @@ export default class Slider extends PureComponent {
aria-valuemin={min}
aria-valuenow={value}
style={thumbStyle}
aria-labelledby={labelId}
/>
<div
className={`${prefix}--slider__track`}
Expand Down