fix(slider): add labelledby to slider div #11798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aledavila
requested review from
jnm2377 and
joshblack
and removed request for
a team
joshblack
approved these changes
Jul 14, 2022
abbeyhrt
approved these changes
Jul 14, 2022
metonym
added a commit
to carbon-design-system/carbon-components-svelte
that referenced
this pull request
Aug 10, 2022
metonym
added a commit
to carbon-design-system/carbon-components-svelte
that referenced
this pull request
Aug 10, 2022
metonym
added a commit
to carbon-design-system/carbon-components-svelte
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11676
Reference: #11797 for v11 fix as well
Changelog
v10 fix
New
aria-labelledbyto slider divrole=sliderTesting / Reviewing
Make sure slider is working as intended. Make sure the label a11y error is gone.