Skip to content

fix(switch): allow children to render #11791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2022
Merged

fix(switch): allow children to render #11791

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b331b25
fix(switch): allow children to render
tay1orjones Jul 12, 2022
800cd6c
test(api): update public api snapshot
tay1orjones Jul 13, 2022
180e96a
Merge branch 'main' into fix-switch-children
tay1orjones Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/components/ContentSwitcher/ContentSwitcher.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default {
export const Default = () => (
<ContentSwitcher onChange={() => {}}>
<Switch name="one" text="First section" />
<Switch name="two" text="Second section" />
<Switch name="two">Second section</Switch>
<Switch name="three" text="Third section" />
</ContentSwitcher>
);
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/components/Switch/Switch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ Switch.propTypes = {

Switch.defaultProps = {
selected: false,
text: 'Provide text',
onClick: () => {},
onKeyDown: () => {},
};
Expand Down