fix(switch): allow children to render #11791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Jul 12, 2022
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
abbeyhrt
approved these changes
Jul 12, 2022
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Jul 13, 2022
* fix(switch): allow children to render * test(api): update public api snapshot
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surfaced in slack, Switch wasn't allowing it's children to render at any time because
textwas always defined via defaultPropsChangelog
Changed
textdefault prop, update storyTesting / Reviewing
In the ContentSwitcher/Default story, the "Second section" is now a child instead of the
textprop, it should render the same as it did before with no change.