Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical alignment of sortable columns vs. non-sortable columns in XL tables #9311

Closed
1 of 2 tasks
wkeese opened this issue Jul 26, 2021 · 3 comments · Fixed by #11404
Closed
1 of 2 tasks

Vertical alignment of sortable columns vs. non-sortable columns in XL tables #9311

wkeese opened this issue Jul 26, 2021 · 3 comments · Fixed by #11404
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities severity: 4 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@wkeese
Copy link
Contributor

wkeese commented Jul 26, 2021

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

With row-size set to XL, the vertical alignment of sortable columns vs. unsortable columns is slightly off. Notice below how "Protocol" is slightly lower than "Name".

Screen Shot 2021-07-26 at 12 25 55

(It is pretty subtle though, only a few pixels.)

This is on Carbon 10.37, tested on the latest versions of Chrome and Firefox on MacOS.

Steps to reproduce the issue

See https://codesandbox.io/s/happy-minsky-n5i5s?file=/index.html.

@sstrubberg
Copy link
Member

@wkeese I went and added the bx--table-sort classname to the div on that column and it straightened things right up.

column

@wkeese
Copy link
Contributor Author

wkeese commented Aug 3, 2021

@sstrubberg - Are you saying I should set bx--table-sort on unsortable columns too? That seems counterintuitive at the least.

@sstrubberg
Copy link
Member

@wkeese That's totally fair. I was just offering up a simple solution. Ideally, we could get a community contribution to update the bx--table-header-label with the proper style.

@sstrubberg sstrubberg reopened this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants